Update CHANGELOG.md (#4002)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

.github/workflows/close-discussion.yml

@@ -1,8 +1,13 @@
 name: Close Discussion on PR Merge
 
 on:
-  pull_request:
+  push:
-    types: [closed]
+    branches:
+      - main
+
+permissions:
+  contents: read
+  discussions: write
 
 jobs:
   close-discussion:
@@ -11,56 +16,82 @@ jobs:
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v4
-        with:
-          repository: community-scripts/ProxmoxVE
-          ref: main
-          token: ${{ secrets.GITHUB_TOKEN }}  
 
       - name: Set Up Node.js
         uses: actions/setup-node@v4
         with:
           node-version: "20"
+
       - name: Install Dependencies
         run: npm install zx @octokit/graphql
 
       - name: Close Discussion
         env:
-          GITHUB_TOKEN: ${{ secrets.PAT_MICHEL }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          PR_BODY: ${{ github.event.pull_request.body }}
+          GITHUB_SHA: ${{ github.sha }}
-          PR_NUMBER: ${{ github.event.pull_request.number }}
+          GITHUB_REPOSITORY: ${{ github.repository }}
-          REPO_OWNER: ${{ github.repository_owner }}
-          REPO_NAME: ${{ github.event.repository.name }}
         run: |
           npx zx << 'EOF'
           import { graphql } from "@octokit/graphql";
-          (async function() {
+
+          (async function () {
             try {
               const token = process.env.GITHUB_TOKEN;
-              const prBody = process.env.PR_BODY;
+              const commitSha = process.env.GITHUB_SHA;
-              const prNumber = process.env.PR_NUMBER;
+              const [owner, repo] = process.env.GITHUB_REPOSITORY.split("/");
-              const owner = process.env.REPO_OWNER;
-              const repo = process.env.REPO_NAME;
 
-              if (!token || !prBody || !prNumber || !owner || !repo) {
+              if (!token || !commitSha || !owner || !repo) {
                 console.log("Missing required environment variables.");
                 process.exit(1);
               }
 
+              const graphqlWithAuth = graphql.defaults({
+                headers: { authorization: `Bearer ${token}` },
+              });
+
+              // Find PR from commit SHA
+              const searchQuery = `
+                query($owner: String!, $repo: String!, $sha: GitObjectID!) {
+                  repository(owner: $owner, name: $repo) {
+                    object(oid: $sha) {
+                      ... on Commit {
+                        associatedPullRequests(first: 1) {
+                          nodes {
+                            number
+                            body
+                          }
+                        }
+                      }
+                    }
+                  }
+                }
+              `;
+
+              const prResult = await graphqlWithAuth(searchQuery, {
+                owner,
+                repo,
+                sha: commitSha,
+              });
+
+              const pr = prResult.repository.object.associatedPullRequests.nodes[0];
+              if (!pr) {
+                console.log("No PR found for this commit.");
+                return;
+              }
+
+              const prNumber = pr.number;
+              const prBody = pr.body;
+
               const match = prBody.match(/#(\d+)/);
               if (!match) {
                 console.log("No discussion ID found in PR body.");
                 return;
               }
+
               const discussionNumber = match[1];
-
               console.log(`Extracted Discussion Number: ${discussionNumber}`);
-              console.log(`PR Number: ${prNumber}`);
-              console.log(`Repository: ${owner}/${repo}`);
-
-              const graphqlWithAuth = graphql.defaults({
-                headers: { authorization: `Bearer ${token}` },
-              });
 
+              // Fetch GraphQL discussion ID
               const discussionQuery = `
                 query($owner: String!, $repo: String!, $number: Int!) {
                   repository(owner: $owner, name: $repo) {
@@ -71,6 +102,8 @@ jobs:
                 }
               `;
 
+              //
+              try {
                 const discussionResponse = await graphqlWithAuth(discussionQuery, {
                   owner,
                   repo,
@@ -82,9 +115,12 @@ jobs:
                   console.log("Failed to fetch discussion GraphQL ID.");
                   return;
                 }
+              } catch (error) {
+                console.error("Discussion not found or error occurred while fetching discussion:", error);
+                return;
+              }
 
-              console.log(`GraphQL Discussion ID: ${discussionQLId}`);
+              // Post comment
-              
               const commentMutation = `
                 mutation($discussionId: ID!, $body: String!) {
                   addDiscussionComment(input: { discussionId: $discussionId, body: $body }) {
@@ -106,6 +142,7 @@ jobs:
 
               console.log(`Comment Posted Successfully! Comment ID: ${commentId}`);
 
+              // Mark comment as answer
               const markAnswerMutation = `
                 mutation($id: ID!) {
                   markDiscussionCommentAsAnswer(input: { id: $id }) {
@@ -120,7 +157,7 @@ jobs:
 
             } catch (error) {
               console.error("Error:", error);
-              return;
+              process.exit(1);
             }
           })();
           EOF

CHANGELOG.md

@@ -14,6 +14,21 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 All LXC instances created using this repository come pre-installed with Midnight Commander, which is a command-line tool (`mc`) that offers a user-friendly file and directory management interface for the terminal environment.
 
 
+## 2025-04-23
+
+### 🚀 Updated Scripts
+
+  - #### 🐞 Bug Fixes
+
+    - Zipline: Add new ENV Variable and Change Update [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#3997](https://github.com/community-scripts/ProxmoxVE/pull/3997))
+    - karakeep: use nightly channel for yt-dlp [@vhsdream](https://github.com/vhsdream) ([#3992](https://github.com/community-scripts/ProxmoxVE/pull/3992))
+
+### 🧰 Maintenance
+
+  - #### 📂 Github
+
+    - Fix Workflow to close discussions [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#3999](https://github.com/community-scripts/ProxmoxVE/pull/3999))
+
 ## 2025-04-22
 
 ### 🆕 New Scripts

ct/karakeep.sh

@@ -33,6 +33,9 @@ function update_script() {
     msg_info "Stopping Services"
     systemctl stop karakeep-web karakeep-workers karakeep-browser
     msg_ok "Stopped Services"
+    msg_info "Updating yt-dlp"
+    $STD yt-dlp --update-to nightly
+    msg_ok "Updated yt-dlp"
     msg_info "Updating ${APP} to v${RELEASE}"
     if [[ $(corepack -v) < "0.31.0" ]]; then
       $STD npm install -g corepack@0.31.0

ct/zipline.sh

@@ -40,10 +40,12 @@ function update_script() {
 
     msg_info "Updating ${APP} to ${RELEASE}"
     cp /opt/zipline/.env /opt/
-    rm -R /opt/zipline
+    mkdir -p /opt/zipline-upload
+    cp -R /opt/zipline/upload/* /opt/zipline-upload/
     curl -fsSL "https://github.com/diced/zipline/archive/refs/tags/v${RELEASE}.zip" -o $(basename "https://github.com/diced/zipline/archive/refs/tags/v${RELEASE}.zip")
-    unzip -q v${RELEASE}.zip
+    unzip -q v"${RELEASE}".zip
-    mv zipline-${RELEASE} /opt/zipline
+    rm -R /opt/zipline
+    mv zipline-"${RELEASE}" /opt/zipline
     cd /opt/zipline
     mv /opt/.env /opt/zipline/.env
     $STD pnpm install
@@ -56,7 +58,7 @@ function update_script() {
     msg_ok "Started ${APP}"
 
     msg_info "Cleaning Up"
-    rm -rf v${RELEASE}.zip
+    rm -rf v"${RELEASE}".zip
     msg_ok "Cleaned"
     msg_ok "Updated Successfully"
   else

frontend/public/json/versions.json

@@ -1,28 +1,13 @@
 [
+  {
+    "name": "Graylog2/graylog2-server",
+    "version": "6.3.0-alpha.1",
+    "date": "2025-04-23T11:25:55Z"
+  },
   {
     "name": "fhem/fhem-mirror",
     "version": "6.2",
-    "date": "2025-04-22T10:34:10Z"
+    "date": "2025-04-23T10:36:12Z"
-  },
-  {
-    "name": "OctoPrint/OctoPrint",
-    "version": "1.11.0",
-    "date": "2025-04-22T09:33:46Z"
-  },
-  {
-    "name": "n8n-io/n8n",
-    "version": "n8n@1.86.1",
-    "date": "2025-04-09T09:20:55Z"
-  },
-  {
-    "name": "zabbix/zabbix",
-    "version": "6.0.40",
-    "date": "2025-04-22T08:43:35Z"
-  },
-  {
-    "name": "Checkmk/checkmk",
-    "version": "v2.4.0b6-rc1",
-    "date": "2025-04-22T08:12:24Z"
   },
   {
     "name": "nzbgetcom/nzbget",
@@ -30,15 +15,135 @@
     "date": "2025-03-18T07:33:51Z"
   },
   {
-    "name": "openobserve/openobserve",
+    "name": "cockpit-project/cockpit",
-    "version": "v0.14.6-rc5",
+    "version": "337",
-    "date": "2025-04-22T06:50:13Z"
+    "date": "2025-04-23T08:26:31Z"
   },
   {
     "name": "mattermost/mattermost",
     "version": "v10.6.2",
     "date": "2025-04-15T08:14:23Z"
   },
+  {
+    "name": "zabbix/zabbix",
+    "version": "7.2.6",
+    "date": "2025-04-23T08:06:23Z"
+  },
+  {
+    "name": "jupyter/notebook",
+    "version": "v7.4.1",
+    "date": "2025-04-23T06:40:34Z"
+  },
+  {
+    "name": "Jackett/Jackett",
+    "version": "v0.22.1815",
+    "date": "2025-04-23T05:56:23Z"
+  },
+  {
+    "name": "openobserve/openobserve",
+    "version": "v0.14.6-rc6",
+    "date": "2025-04-23T04:24:27Z"
+  },
+  {
+    "name": "jhuckaby/Cronicle",
+    "version": "v0.9.78",
+    "date": "2025-04-23T01:38:28Z"
+  },
+  {
+    "name": "grafana/grafana",
+    "version": "v11.3.6",
+    "date": "2025-04-23T00:18:05Z"
+  },
+  {
+    "name": "cross-seed/cross-seed",
+    "version": "v6.11.2",
+    "date": "2025-02-26T14:54:49Z"
+  },
+  {
+    "name": "minio/minio",
+    "version": "RELEASE.2025-04-22T22-12-26Z",
+    "date": "2025-04-22T22:44:34Z"
+  },
+  {
+    "name": "docmost/docmost",
+    "version": "v0.20.0",
+    "date": "2025-04-22T22:30:25Z"
+  },
+  {
+    "name": "glanceapp/glance",
+    "version": "v0.7.13",
+    "date": "2025-04-22T22:19:16Z"
+  },
+  {
+    "name": "netbox-community/netbox",
+    "version": "v4.2.8",
+    "date": "2025-04-22T19:44:49Z"
+  },
+  {
+    "name": "keycloak/keycloak",
+    "version": "26.2.0",
+    "date": "2025-04-11T12:48:27Z"
+  },
+  {
+    "name": "donaldzou/WGDashboard",
+    "version": "v4.2.0",
+    "date": "2025-04-22T18:18:28Z"
+  },
+  {
+    "name": "n8n-io/n8n",
+    "version": "n8n@1.90.0",
+    "date": "2025-04-22T08:58:15Z"
+  },
+  {
+    "name": "NodeBB/NodeBB",
+    "version": "v4.2.2",
+    "date": "2025-04-22T16:33:53Z"
+  },
+  {
+    "name": "jenkinsci/jenkins",
+    "version": "jenkins-2.507",
+    "date": "2025-04-22T15:22:53Z"
+  },
+  {
+    "name": "evcc-io/evcc",
+    "version": "0.203.2",
+    "date": "2025-04-22T15:07:28Z"
+  },
+  {
+    "name": "Checkmk/checkmk",
+    "version": "v2.4.0b6",
+    "date": "2025-04-22T15:00:31Z"
+  },
+  {
+    "name": "zwave-js/zwave-js-ui",
+    "version": "v10.3.0",
+    "date": "2025-04-22T14:57:47Z"
+  },
+  {
+    "name": "OliveTin/OliveTin",
+    "version": "2025.4.22",
+    "date": "2025-04-22T14:18:11Z"
+  },
+  {
+    "name": "mongodb/mongo",
+    "version": "r8.2.0-alpha",
+    "date": "2025-04-22T13:19:07Z"
+  },
+  {
+    "name": "AdguardTeam/AdGuardHome",
+    "version": "v0.107.61",
+    "date": "2025-04-22T12:42:26Z"
+  },
+  {
+    "name": "VictoriaMetrics/VictoriaMetrics",
+    "version": "v1.20.0-victorialogs",
+    "date": "2025-04-22T12:00:23Z"
+  },
+  {
+    "name": "OctoPrint/OctoPrint",
+    "version": "1.11.0",
+    "date": "2025-04-22T09:33:46Z"
+  },
   {
     "name": "morpheus65535/bazarr",
     "version": "v1.5.1",
@@ -49,21 +154,11 @@
     "version": "v6.2.12",
     "date": "2025-04-20T19:22:17Z"
   },
-  {
-    "name": "Jackett/Jackett",
-    "version": "v0.22.1809",
-    "date": "2025-04-22T05:55:35Z"
-  },
   {
     "name": "monicahq/monica",
     "version": "v4.1.2",
     "date": "2024-05-04T08:06:50Z"
   },
-  {
-    "name": "OliveTin/OliveTin",
-    "version": "2025.4.21",
-    "date": "2025-04-21T19:16:09Z"
-  },
   {
     "name": "Suwayomi/Suwayomi-Server",
     "version": "v2.0.1727",
@@ -84,21 +179,6 @@
     "version": "v3.10.0-beta.9",
     "date": "2025-04-17T11:46:08Z"
   },
-  {
-    "name": "AdguardTeam/AdGuardHome",
-    "version": "v0.107.60",
-    "date": "2025-04-14T11:46:19Z"
-  },
-  {
-    "name": "keycloak/keycloak",
-    "version": "26.2.0",
-    "date": "2025-04-11T12:48:27Z"
-  },
-  {
-    "name": "cross-seed/cross-seed",
-    "version": "v6.11.2",
-    "date": "2025-02-26T14:54:49Z"
-  },
   {
     "name": "Prowlarr/Prowlarr",
     "version": "v1.34.1.5021",
@@ -249,11 +329,6 @@
     "version": "v4.99.3",
     "date": "2025-04-17T18:33:11Z"
   },
-  {
-    "name": "VictoriaMetrics/VictoriaMetrics",
-    "version": "v1.19.0-victorialogs",
-    "date": "2025-04-17T18:26:31Z"
-  },
   {
     "name": "duplicati/duplicati",
     "version": "v2.1.0.116-2.1.0.116_canary_2025-04-17",
@@ -294,11 +369,6 @@
     "version": "2025.4.0",
     "date": "2025-04-17T00:55:34Z"
   },
-  {
-    "name": "docmost/docmost",
-    "version": "v0.10.2",
-    "date": "2025-04-16T20:43:40Z"
-  },
   {
     "name": "forgejo/forgejo",
     "version": "v11.0.0",
@@ -309,11 +379,6 @@
     "version": "v1.129.0rc1",
     "date": "2025-04-16T15:18:13Z"
   },
-  {
-    "name": "jenkinsci/jenkins",
-    "version": "jenkins-2.506",
-    "date": "2025-04-15T15:40:50Z"
-  },
   {
     "name": "wazuh/wazuh",
     "version": "coverity-w17-4.12.0",
@@ -354,11 +419,6 @@
     "version": "v0.14.1",
     "date": "2024-08-29T22:32:51Z"
   },
-  {
-    "name": "netbox-community/netbox",
-    "version": "v4.2.7",
-    "date": "2025-04-10T20:08:13Z"
-  },
   {
     "name": "home-assistant/operating-system",
     "version": "15.2",
@@ -369,11 +429,6 @@
     "version": "v0.0.7-hf1",
     "date": "2025-03-10T20:49:39Z"
   },
-  {
-    "name": "Graylog2/graylog2-server",
-    "version": "6.2.0-rc.1",
-    "date": "2025-04-14T11:26:18Z"
-  },
   {
     "name": "bluenviron/mediamtx",
     "version": "v1.12.0",
@@ -384,21 +439,6 @@
     "version": "v0.6.5",
     "date": "2025-04-14T09:13:36Z"
   },
-  {
-    "name": "zwave-js/zwave-js-ui",
-    "version": "v10.2.0",
-    "date": "2025-04-14T08:53:44Z"
-  },
-  {
-    "name": "evcc-io/evcc",
-    "version": "0.203.1",
-    "date": "2025-04-14T07:23:02Z"
-  },
-  {
-    "name": "glanceapp/glance",
-    "version": "v0.7.12",
-    "date": "2025-04-14T00:16:15Z"
-  },
   {
     "name": "rogerfar/rdt-client",
     "version": "v2.0.108",
@@ -474,21 +514,6 @@
     "version": "cassandra-5.0.4",
     "date": "2025-04-10T16:32:00Z"
   },
-  {
-    "name": "NodeBB/NodeBB",
-    "version": "v4.2.1",
-    "date": "2025-04-10T14:03:47Z"
-  },
-  {
-    "name": "mongodb/mongo",
-    "version": "r8.0.5-rc2",
-    "date": "2025-04-09T22:37:52Z"
-  },
-  {
-    "name": "jupyter/notebook",
-    "version": "v7.4.0",
-    "date": "2025-04-09T17:36:14Z"
-  },
   {
     "name": "glpi-project/glpi",
     "version": "10.0.18",
@@ -499,11 +524,6 @@
     "version": "v2.69.10",
     "date": "2025-04-09T12:16:51Z"
   },
-  {
-    "name": "minio/minio",
-    "version": "RELEASE.2025-04-08T15-41-24Z",
-    "date": "2025-04-08T19:51:06Z"
-  },
   {
     "name": "goauthentik/authentik",
     "version": "version/2025.2.4",
@@ -724,11 +744,6 @@
     "version": "5.2.1",
     "date": "2025-03-28T13:00:23Z"
   },
-  {
-    "name": "cockpit-project/cockpit",
-    "version": "336.2",
-    "date": "2025-03-28T10:16:47Z"
-  },
   {
     "name": "gethomepage/homepage",
     "version": "v1.1.1",
@@ -744,11 +759,6 @@
     "version": "v1.34.0",
     "date": "2025-03-26T08:48:34Z"
   },
-  {
-    "name": "grafana/grafana",
-    "version": "v11.6.0",
-    "date": "2025-03-25T22:10:15Z"
-  },
   {
     "name": "ipfs/kubo",
     "version": "v0.34.1",
@@ -809,11 +819,6 @@
     "version": "250321-57590c48b",
     "date": "2025-03-21T11:48:16Z"
   },
-  {
-    "name": "jhuckaby/Cronicle",
-    "version": "v0.9.77",
-    "date": "2025-03-21T02:25:42Z"
-  },
   {
     "name": "seanmorley15/AdventureLog",
     "version": "v0.9.0",
@@ -1069,11 +1074,6 @@
     "version": "v0.2.1",
     "date": "2025-01-19T22:40:40Z"
   },
-  {
-    "name": "donaldzou/WGDashboard",
-    "version": "v4.1.4",
-    "date": "2025-01-19T13:14:19Z"
-  },
   {
     "name": "0xERR0R/blocky",
     "version": "v0.25",

install/karakeep-install.sh

@@ -29,7 +29,7 @@ msg_ok "Installed Dependencies"
 msg_info "Installing Additional Tools"
 curl -fsSL "https://github.com/Y2Z/monolith/releases/latest/download/monolith-gnu-linux-x86_64" -o "/usr/bin/monolith"
 chmod +x /usr/bin/monolith
-curl -fsSL "https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp_linux" -o "/usr/bin/yt-dlp"
+curl -fsSL "https://github.com/yt-dlp/yt-dlp-nightly-builds/releases/latest/download/yt-dlp_linux" -o "/usr/bin/yt-dlp"
 chmod +x /usr/bin/yt-dlp
 msg_ok "Installed Additional Tools"
 

install/zipline-install.sh

@@ -53,8 +53,8 @@ msg_info "Installing Zipline (Patience)"
 cd /opt
 RELEASE=$(curl -fsSL https://api.github.com/repos/diced/zipline/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
 curl -fsSL "https://github.com/diced/zipline/archive/refs/tags/v${RELEASE}.zip" -o $(basename "https://github.com/diced/zipline/archive/refs/tags/v${RELEASE}.zip")
-unzip -q v${RELEASE}.zip
+unzip -q v"${RELEASE}".zip
-mv zipline-${RELEASE} /opt/zipline
+mv zipline-"${RELEASE}" /opt/zipline
 cd /opt/zipline
 cat <<EOF >/opt/zipline/.env
 DATABASE_URL=postgres://$DB_USER:$DB_PASS@localhost:5432/$DB_NAME
@@ -62,7 +62,10 @@ CORE_SECRET=$SECRET_KEY
 CORE_HOSTNAME=0.0.0.0
 CORE_PORT=3000
 CORE_RETURN_HTTPS=false
+DATASOURCE_TYPE=local
+DATASOURCE_LOCAL_DIRECTORY=/opt/zipline-upload
 EOF
+mkdir -p /opt/zipline-upload
 $STD pnpm install
 $STD pnpm build
 echo "${RELEASE}" >"/opt/${APPLICATION}_version.txt"

tools/pve/post-pve-install.sh

@@ -179,8 +179,20 @@ EOF
       msg_info "Disabling high availability"
       systemctl disable -q --now pve-ha-lrm
       systemctl disable -q --now pve-ha-crm
-      systemctl disable -q --now corosync
       msg_ok "Disabled high availability"
+      CHOICE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "COROSYNC" --menu "Disable Corosync for a Proxmox VE Cluster?" 10 58 2 \
+        "yes" " " \
+        "no" " " 3>&2 2>&1 1>&3)
+      case $CHOICE in
+      yes)
+        msg_info "Disabling Corosync"
+        systemctl disable -q --now corosync
+        msg_ok "Disabled Corosync"
+        ;;
+      no)
+        msg_error "Selected no to Disabling Corosync"
+        ;;
+      esac
       ;;
     no)
       msg_error "Selected no to Disabling high availability"