Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore 📦: Optimize swap settings for better performance #27

Merged
Jose merged 2 commits from dev into main 2026-02-15 08:16:46 +01:00
Conversation 1 Commits 2 Files Changed 2 +18 -6
Jose commented 2026-02-15 08:14:03 +01:00
Owner
Copy Link

This commit removes an unused repository management task from the build process to clean up unnecessary steps and streamline the workflow.

This commit removes an unused repository management task from the build process to clean up unnecessary steps and streamline the workflow.
Jose added 2 commits 2026-02-15 08:14:04 +01:00
chore 📦: Ensure Proxmox compatibility by disabling enterprise repo, removing subscription nag, and tuning swap b01f1e3d55 
This commit ensures compatibility with Proxmox environments by making several configuration changes. It disables the enterprise repository to avoid licensing issues, removes the subscription nag message to streamline user experience, and optimizes the swap settings for better performance.
chore 📦: Remove unused repository management task
All checks were successful
ansible-lint / Ansible Lint (push) Successful in 12s
Details
Gitleaks Scan / gitleaks (push) Successful in 5s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 18s
Details
PR check / Gitleaks (pull_request) Successful in 4s
Details
PR check / lint tests (pull_request) Successful in 14s
Details
PR check / labeler (pull_request) Successful in 3s
Details
PR check / handle_failures (pull_request) Has been skipped
Details
PR check / handle_success (pull_request) Successful in 1s
Details
e0a3c2464b 
This commit removes an unused repository management task from the build process to clean up unnecessary steps and streamline the workflow.
gitea-actions bot reviewed 2026-02-15 08:14:22 +01:00
gitea-actions bot left a comment
Copy Link

Review Summary

  • tasks/main.yml: Addition of Proxmox check and stopping script execution if it's not a Proxmox VE node: This change is a good practice as it ensures the script will not be executed on non-Proxmox systems, thus avoiding potential errors and enhancing security. [Score: 3] The remaining changes are the reordering of tasks related to Proxmox and the addition/removal of some unrelated tasks. These changes do not significantly affect logic, security, performance, or maintainability. [Score: 2]
  • tasks/repos.yml: Summary: Removed a commented-out Ansible task managing Proxmox repositories.
# Review Summary * **tasks/main.yml**: Addition of Proxmox check and stopping script execution if it's not a Proxmox VE node: This change is a good practice as it ensures the script will not be executed on non-Proxmox systems, thus avoiding potential errors and enhancing security. [Score: 3] The remaining changes are the reordering of tasks related to Proxmox and the addition/removal of some unrelated tasks. These changes do not significantly affect logic, security, performance, or maintainability. [Score: 2] * **tasks/repos.yml**: **Summary:** Removed a commented-out Ansible task managing Proxmox repositories.
tasks/repos.yml
@@ -2,4 +2,3 @@
- name: repos | Manage Proxmox repositories
vars:
repo_path:
gitea-actions bot commented 2026-02-15 08:14:22 +01:00
Copy Link

[Lines 1-4] [Score: 2] Removing unused task might improve maintainability. Consider keeping if it's intended for future use.

[Lines 1-4] [Score: 2] Removing unused task might improve maintainability. Consider keeping if it's intended for future use.
gitea-actions bot added the sourceci-pass labels 2026-02-15 08:14:47 +01:00
Jose changed title from chore 📦: Remove unused repository management task to chore 📦: Optimize swap settings for better performance 2026-02-15 08:16:35 +01:00
Jose merged commit 7b4991ee43 into main 2026-02-15 08:16:46 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Documentation
bug
Something is not working
 ci-failed
action test workflow failed
 ci-pass
action test workflow pass
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 source
wontfix
This won't be fixed
No Label ci-pass source
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jose
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Jose/ansible_role_proxmox_provision#27
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?