Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor ♻️: Refactor memory calculation logic #35

Merged
Jose merged 1 commits from dev into main 2026-02-15 17:40:30 +01:00
Conversation 1 Commits 1 Files Changed 2 +2 -3
Jose commented 2026-02-15 17:38:45 +01:00
Owner
Copy Link

Removed unused variable and updated memory calculation to use ansible_memtotal_mb for more accurate results.

Removed unused variable and updated memory calculation to use ansible_memtotal_mb for more accurate results.
Jose added 1 commit 2026-02-15 17:38:46 +01:00
refactor ♻️: Refactor memory calculation logic
All checks were successful
ansible-lint / Ansible Lint (push) Successful in 14s
Details
Gitleaks Scan / gitleaks (push) Successful in 5s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 31s
Details
PR check / Gitleaks (pull_request) Successful in 4s
Details
PR check / lint tests (pull_request) Successful in 15s
Details
PR check / labeler (pull_request) Successful in 2s
Details
PR check / handle_failures (pull_request) Has been skipped
Details
PR check / handle_success (pull_request) Successful in 1s
Details
23376f81f7 
Removed unused variable and updated memory calculation to use ansible_memtotal_mb for more accurate results.
gitea-actions bot reviewed 2026-02-15 17:39:17 +01:00
gitea-actions bot left a comment
Copy Link

Review Summary

  • defaults/main.yml: Removed hardcoded memory limit for log2ram_host_memtotal_mb configuration. This change may increase the system's flexibility, but it could potentially lead to excessive RAM usage if not properly managed. It is recommended to set an appropriate default value or use a dynamic calculation based on available system resources.
  • tasks/ram.yml: Changes Calculate the RAM size using ansible_memtotal_mb instead of log2ram_host_memtotal_mb. This could potentially lead to incorrect calculations if the host and the fact variables differ.
# Review Summary * **defaults/main.yml**: Removed hardcoded memory limit for `log2ram_host_memtotal_mb` configuration. This change may increase the system's flexibility, but it could potentially lead to excessive RAM usage if not properly managed. It is recommended to set an appropriate default value or use a dynamic calculation based on available system resources. * **tasks/ram.yml**: Changes Calculate the RAM size using `ansible_memtotal_mb` instead of `log2ram_host_memtotal_mb`. This could potentially lead to incorrect calculations if the host and the fact variables differ.
defaults/main.yml
@@ -38,4 +38,3 @@
log2ram_min_size_mb: 128
log2ram_max_size_mb: 1024
log2ram_host_memtotal_mb: "{{ host_memtotal_mb | default(4086) }}"
gitea-actions bot commented 2026-02-15 17:39:17 +01:00
Copy Link

[Score: 3] Removing hardcoded memory limit for log2ram_host_memtotal_mb could potentially lead to excessive RAM usage if not properly managed. It is recommended to set an appropriate default value or use a dynamic calculation based on available system resources.

[Score: 3] Removing hardcoded memory limit for log2ram_host_memtotal_mb could potentially lead to excessive RAM usage if not properly managed. It is recommended to set an appropriate default value or use a dynamic calculation based on available system resources.
gitea-actions bot added the sourceci-pass labels 2026-02-15 17:40:12 +01:00
Jose merged commit e965fcaf7f into main 2026-02-15 17:40:30 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Documentation
bug
Something is not working
 ci-failed
action test workflow failed
 ci-pass
action test workflow pass
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 source
wontfix
This won't be fixed
No Label ci-pass source
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jose
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Jose/ansible_role_proxmox_provision#35
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?