Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat ✨: Add variable log2ram_host_memtotal_mb for storing host memory total in MB #39

Merged
Jose merged 1 commits from dev into main 2026-02-16 18:28:08 +01:00
Conversation 1 Commits 1 Files Changed 1 +1 -3
Jose commented 2026-02-16 18:26:50 +01:00
Owner
Copy Link

Introduce a new variable to store the total memory of the host in megabytes, enhancing memory management and resource allocation within the system.

Introduce a new variable to store the total memory of the host in megabytes, enhancing memory management and resource allocation within the system.
Jose added 1 commit 2026-02-16 18:26:50 +01:00
chore 📦: Update log2ram URL to use a specific tag
All checks were successful
ansible-lint / Ansible Lint (push) Successful in 13s
Details
Gitleaks Scan / gitleaks (push) Successful in 5s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 12s
Details
PR check / Gitleaks (pull_request) Successful in 4s
Details
PR check / lint tests (pull_request) Successful in 16s
Details
PR check / labeler (pull_request) Successful in 3s
Details
PR check / handle_failures (pull_request) Has been skipped
Details
PR check / handle_success (pull_request) Successful in 1s
Details
06834ae66b 
This commit updates the URL for log2ram to point to a specific tag rather than using the master branch. This ensures that we are always using a stable version of the software.
gitea-actions bot reviewed 2026-02-16 18:27:15 +01:00
gitea-actions bot left a comment
Copy Link

Review Summary

  • tasks/ram.yml: Summary: The provided Git diff focuses on updating the version of a package (log2ram) to a specific tag. There are no major logic issues, performance bottlenecks, or security concerns found. However, there's a potential maintainability issue due to hardcoding the version number, which could lead to problems in future updates.
# Review Summary * **tasks/ram.yml**: **Summary:** The provided Git diff focuses on updating the version of a package (log2ram) to a specific tag. There are no major logic issues, performance bottlenecks, or security concerns found. However, there's a potential maintainability issue due to hardcoding the version number, which could lead to problems in future updates.
tasks/ram.yml
@@ -39,10 +39,8 @@
- name: ram | Download log2ram
ansible.builtin.get_url:
gitea-actions bot commented 2026-02-16 18:27:15 +01:00
Copy Link

[Score: 3] Hardcoding the version number may cause issues in future updates. Consider using a dependency management tool like Ansible Galaxy or pip install to manage package versions and automate updates.

[Score: 3] Hardcoding the version number may cause issues in future updates. Consider using a dependency management tool like Ansible Galaxy or `pip install` to manage package versions and automate updates.
gitea-actions bot added the sourceci-pass labels 2026-02-16 18:27:43 +01:00
Jose merged commit 2e570f6808 into main 2026-02-16 18:28:08 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Documentation
bug
Something is not working
 ci-failed
action test workflow failed
 ci-pass
action test workflow pass
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 source
wontfix
This won't be fixed
No Label ci-pass source
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jose
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Jose/ansible_role_proxmox_provision#39
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?