fix 🐛: Fix typo in firewall path variable #45

Jose · 2026-02-25T17:39:21+01:00

Jose commented

2026-02-25 17:39:21 +01:00

Corrected a typographical error in the firewall path variable to ensure proper configuration and functionality.

Jose added 1 commit 2026-02-25 17:39:22 +01:00

fix 🐛: Fix typo in firewall path variable

ansible-lint / Ansible Lint (push) Successful in 13s

Details

Gitleaks Scan / gitleaks (push) Successful in 4s

Details

Markdown Lint / markdown-lint (push) Successful in 5s

Details

ai-reviews / Review PR (pull_request) Successful in 12s

Details

PR check / Gitleaks (pull_request) Successful in 4s

Details

PR check / lint tests (pull_request) Successful in 16s

Details

PR check / labeler (pull_request) Successful in 2s

Details

PR check / handle_failures (pull_request) Has been skipped

Details

PR check / handle_success (pull_request) Successful in 1s

Details

46cac8fc90

Corrected a typographical error in the firewall path variable to ensure proper configuration and functionality.

gitea-actions bot reviewed 2026-02-25 17:39:56 +01:00

gitea-actions bot left a comment

Review Summary

tasks/fail2ban.yml: The changes made to tasks/fail2ban.yml involve a minor modification in the way the firewall configuration file path is constructed for non-clustered environments. The old code checked whether the system is clustered and if not, it concatenated '/etc/pve/firewall/' with the output of pve_node.stdout (the node's name). The new code directly uses the pve_node variable to construct the file path for non-clustered environments. While this change does not introduce any major logic errors or performance issues, it is a good practice to use variables directly when they are available and avoid using functions like stdout if possible. This makes the code more readable and maintainable.

# Review Summary * **tasks/fail2ban.yml**: The changes made to tasks/fail2ban.yml involve a minor modification in the way the firewall configuration file path is constructed for non-clustered environments. The old code checked whether the system is clustered and if not, it concatenated '/etc/pve/firewall/' with the output of pve_node.stdout (the node's name). The new code directly uses the pve_node variable to construct the file path for non-clustered environments. While this change does not introduce any major logic errors or performance issues, it is a good practice to use variables directly when they are available and avoid using functions like stdout if possible. This makes the code more readable and maintainable.

tasks/fail2ban.yml

						
				@@ -31,3 +31,3 @@

				        '/etc/pve/firewall/cluster.fw'

				        if pve_clustered

				        else '/etc/pve/firewall/' + pve_node.stdout + '.fw'

				        else '/etc/pve/firewall/' + pve_node + '.fw'