Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore 📦: Remove commented-out code in fail2ban.yml #48

Merged
Jose merged 1 commits from dev into main 2026-03-01 12:07:05 +01:00
Conversation 1 Commits 1 Files Changed 1 -1
Jose commented 2026-03-01 12:06:01 +01:00
Owner
Copy Link

This commit removes unnecessary commented-out code from the fail2ban.yml file to clean up and simplify the configuration.

This commit removes unnecessary commented-out code from the fail2ban.yml file to clean up and simplify the configuration.
Jose added 1 commit 2026-03-01 12:06:02 +01:00
chore 📦: Remove commented-out code in fail2ban.yml
All checks were successful
ansible-lint / Ansible Lint (push) Successful in 14s
Details
Gitleaks Scan / gitleaks (push) Successful in 4s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 12s
Details
PR check / Gitleaks (pull_request) Successful in 5s
Details
PR check / lint tests (pull_request) Successful in 16s
Details
PR check / labeler (pull_request) Successful in 2s
Details
PR check / handle_failures (pull_request) Has been skipped
Details
PR check / handle_success (pull_request) Successful in 2s
Details
54f3f761c8 
This commit removes unnecessary commented-out code from the fail2ban.yml file to clean up and simplify the configuration.
gitea-actions bot reviewed 2026-03-01 12:06:28 +01:00
gitea-actions bot left a comment
Copy Link

Review Summary

  • tasks/fail2ban.yml: Summary: This diff removes a conditional comment related to Corosync Networks, possibly due to the absence of PMXCFS (Proxmox VE Cluster File System). The change could potentially affect the configuration if the system runs in a clustered environment with Corosync.
# Review Summary * **tasks/fail2ban.yml**: **Summary:** This diff removes a conditional comment related to Corosync Networks, possibly due to the absence of PMXCFS (Proxmox VE Cluster File System). The change could potentially affect the configuration if the system runs in a clustered environment with Corosync.
tasks/fail2ban.yml
@@ -97,4 +97,3 @@
# {% if pmxcfs_running.stat.exists %} {{ corosync_networks | join(' ') }}{% endif %}
#################################################
# SSH
gitea-actions bot commented 2026-03-01 12:06:28 +01:00
Copy Link

[Lines 94-99] [Score: 3] The removal of the conditional comment related to Corosync Networks may lead to incorrect configuration if the system runs in a clustered environment with Corosync. It is recommended to either revert this change or add the missing logic for PMXCFS_RUNNING.stat.exists condition when necessary.

[Lines 94-99] [Score: 3] The removal of the conditional comment related to Corosync Networks may lead to incorrect configuration if the system runs in a clustered environment with Corosync. It is recommended to either revert this change or add the missing logic for PMXCFS_RUNNING.stat.exists condition when necessary.
gitea-actions bot added the sourceci-pass labels 2026-03-01 12:06:56 +01:00
Jose merged commit a18dda51ac into main 2026-03-01 12:07:05 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Documentation
bug
Something is not working
 ci-failed
action test workflow failed
 ci-pass
action test workflow pass
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 source
wontfix
This won't be fixed
No Label ci-pass source
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jose
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Jose/ansible_role_proxmox_provision#48
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?