Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs 📝: Add 'API Utilities' section and update directory structure #10

Merged
Jose merged 4 commits from dev into main 2026-02-12 21:29:37 +01:00
Conversation 3 Commits 4 Files Changed 6 +3 -3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c6288877e8 - Show all commits

6
tasks/logrotate.yml
View File

@@ -1,5 +1,5 @@
---
gitea-actions commented 2026-02-12 21:28:45 +01:00
Review
Copy Link

[Score: 3] Removing the YAML document declaration is discouraged as it enables consistency across files and can help with understanding the structure of the playbook. Although not a critical issue, it is recommended to keep it for maintainability purposes.

[Score: 3] Removing the YAML document declaration is discouraged as it enables consistency across files and can help with understanding the structure of the playbook. Although not a critical issue, it is recommended to keep it for maintainability purposes.
- name: "Proxmox | Ensure logrotate is installed"
- name: logrotate | Ensure logrotate is installed
ansible.builtin.apt:
name: logrotate
state: present
@@ -7,7 +7,7 @@
become: true
gitea-actions commented 2026-02-12 21:24:58 +01:00
Review
Copy Link

[Lines 2-7] [Score: 2] The addition of a new task to ensure that the logrotate package is present on the system is a good practice for proper log management. However, it may not be necessary if the system already has logrotate installed by default or if an alternative solution for managing logs is in place.

[Lines 2-7] [Score: 2] The addition of a new task to ensure that the logrotate package is present on the system is a good practice for proper log management. However, it may not be necessary if the system already has logrotate installed by default or if an alternative solution for managing logs is in place.
when: proxmox_logrotate_enabled
- name: logrotate | pve logrotate policy
- name: logrotate | PVE logrotate policy
ansible.builtin.template:
src: pve-logrotate.j2
dest: "/etc/logrotate.d/99-pve-custom"
@@ -18,7 +18,7 @@
when: proxmox_logrotate_enabled
notify: Restart logrotate
- name: logrotate | pve-firewall logrotate policy
- name: logrotate | PVE-firewall logrotate policy
ansible.builtin.template:
src: pve-firewall-logrotate.j2
dest: "/etc/logrotate.d/99-pve-firewall-custom"