Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor ♻️: Refactor Proxmox repository management #5

Merged
Jose merged 5 commits from dev into main 2026-02-08 20:09:56 +01:00
Conversation 3 Commits 5 Files Changed 4 +9 -5
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e680fdf162 - Show all commits

14
tasks/repos.yml
View File

@@ -1,7 +1,11 @@
---
- name: repos | Manage Proxmox repositories
block:
- name: repos | Manage Proxmox repositories
vars:
repo_path:
- http://download\.proxmox\.com/debian/pve\
block:
gitea-actions commented 2026-02-08 20:05:10 +01:00
Review
Copy Link

[Lines 6-8] [Score: 2] Const declarations are generally preferred for variable declaration. It makes the code more explicit and easier to understand, especially when dealing with complex data structures or multiple variables with the same type. Here, const repo_path could be used instead of var.

[Lines 6-8] [Score: 2] Const declarations are generally preferred for variable declaration. It makes the code more explicit and easier to understand, especially when dealing with complex data structures or multiple variables with the same type. Here, `const repo_path` could be used instead of `var`.
#Proxmox enterprise repo
- name: repos | Check for Proxmox enterprise repo file
@@ -27,7 +31,7 @@
- name: repos | Uncomment Proxmox no-subscription repo if present
ansible.builtin.replace:
path: /etc/apt/sources.list.d/pve-install-repo.list
regexp: '^#\s*(deb\s+http://download\.proxmox\.com/debian/pve\s+{{ ansible_distribution_release }}\s+pve-no-subscription)'
regexp: '^#\s*(deb\s+{{ repo_path }}s+{{ ansible_distribution_release }}\s+pve-no-subscription)'
replace: '\1'
gitea-actions commented 2026-02-08 20:05:10 +01:00
Review
Copy Link

[Lines 34-35] [Score: 2] Use a more descriptive regex pattern for better readability. For example, ^#\s*deb\s+{{ repo_path }}\s+[a-zA-Z]+s+\s+pve-no-subscription

[Lines 34-35] [Score: 2] Use a more descriptive regex pattern for better readability. For example, `^#\s*deb\s+{{ repo_path }}\s+[a-zA-Z]+s+\s+pve-no-subscription`
when: pve_install_repo.stat.exists
register: no_sub_uncommented
@@ -35,13 +39,13 @@
- name: repos | Add Proxmox no-subscription repo if missing
ansible.builtin.lineinfile:
path: /etc/apt/sources.list.d/pve-install-repo.list
regexp: '^deb\s+http://download\.proxmox\.com/debian/pve\s+{{ ansible_distribution_release }}\s+pve-no-subscription$'
regexp: '^deb\s+{{ repo_path }}s+{{ ansible_distribution_release }}\s+pve-no-subscription$'
line: "deb http://download.proxmox.com/debian/pve {{ ansible_distribution_release }} pve-no-subscription"
gitea-actions commented 2026-02-08 20:05:10 +01:00
Review
Copy Link

[Lines 42-43] [Score: 2] Use a more descriptive regex pattern for better readability. For example, ^deb\s*{{ repo_path }}\s+[a-zA-Z]+s+\s+pve-no-subscription$

[Lines 42-43] [Score: 2] Use a more descriptive regex pattern for better readability. For example, `^deb\s*{{ repo_path }}\s+[a-zA-Z]+s+\s+pve-no-subscription$`
state: present
insertafter: EOF
when: pve_install_repo.stat.exists
register: no_sub_added
# Notify Run apt update only once if any of the above tasks changed something
notify:
- Run apt update