Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor ♻️: Check for firewall file existence before debugging #51

Merged
Jose merged 1 commits from dev into main 2026-03-01 20:05:15 +01:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 38831f981a - Show all commits

2
tasks/fail2ban.yml
View File

@@ -182,7 +182,7 @@
ansible.builtin.debug:
msg: >
{{ fw_content }}
when: not pve_firewall_enabled
when: fw_stat.stat.exists | default(false)
gitea-actions commented 2026-03-01 20:04:33 +01:00
Review
Copy Link

[Score: 3] It's better to handle cases where the firewall file might not exist explicitly instead of relying on defaults.

[Score: 3] It's better to handle cases where the firewall file might not exist explicitly instead of relying on defaults.
- name: fail2ban | Determine if firewall enabled
ansible.builtin.set_fact: