diff --git a/tasks/install.yml b/tasks/install.yml index f4cc7f8..ffe36af 100644 --- a/tasks/install.yml +++ b/tasks/install.yml @@ -22,36 +22,36 @@ # known regression in certain Samba 4.22.x builds -- name: Check installed Samba version - ansible.builtin.command: samba --version - register: samba_version - changed_when: false - failed_when: false +# - name: Check installed Samba version +# ansible.builtin.command: samba --version +# register: samba_version +# changed_when: false +# failed_when: false -- name: Show installed Samba version - ansible.builtin.debug: - msg: "Samba version: {{ samba_version.stdout }}" +# - name: Show installed Samba version +# ansible.builtin.debug: +# msg: "Samba version: {{ samba_version.stdout }}" -- name: Warn if Samba version is 4.22.4 - ansible.builtin.debug: - msg: "⚠️ Detected buggy Samba version 4.22.4 — upgrade recommended!" - when: "'4.22.4' in samba_version.stdout" +# - name: Warn if Samba version is 4.22.4 +# ansible.builtin.debug: +# msg: "⚠️ Detected buggy Samba version 4.22.4 — upgrade recommended!" +# when: "'4.22.4' in samba_version.stdout" -- name: Add Samba Team Debian GPG key (modern method) - ansible.builtin.get_url: - # url: https://pkg.samba.org/keys/samba-pubkey.asc - url: https://download.samba.org/pub/samba/samba-pubkey.asc - dest: /usr/share/keyrings/samba-team-archive-keyring.gpg - mode: '0644' - when: "'4.22.4' in samba_version.stdout" +# - name: Add Samba Team Debian GPG key (modern method) +# ansible.builtin.get_url: +# # url: https://pkg.samba.org/keys/samba-pubkey.asc +# url: https://download.samba.org/pub/samba/samba-pubkey.asc +# dest: /usr/share/keyrings/samba-team-archive-keyring.gpg +# mode: '0644' +# when: "'4.22.4' in samba_version.stdout" -- name: Add Samba Team Debian repository (modern method) - ansible.builtin.apt_repository: - # repo: "deb [signed-by=/usr/share/keyrings/samba-team-archive-keyring.gpg] http://pkg.samba.org/packages/debian {{ ansible_lsb.codename | default('bookworm') }} samba-422" - repo: "deb [signed-by=/usr/share/keyrings/samba-team-archive-keyring.gpg] http://download.samba.org/pub/samba/packages/debian {{ ansible_distribution_release }} samba-422" - state: present - filename: samba-team - when: "'4.22.4' in samba_version.stdout" +# - name: Add Samba Team Debian repository (modern method) +# ansible.builtin.apt_repository: +# # repo: "deb [signed-by=/usr/share/keyrings/samba-team-archive-keyring.gpg] http://pkg.samba.org/packages/debian {{ ansible_lsb.codename | default('bookworm') }} samba-422" +# repo: "deb [signed-by=/usr/share/keyrings/samba-team-archive-keyring.gpg] http://download.samba.org/pub/samba/packages/debian {{ ansible_distribution_release }} samba-422" +# state: present +# filename: samba-team +# when: "'4.22.4' in samba_version.stdout" # - name: Add Samba Team Debian GPG key (only if upgrade is needed) # ansible.builtin.apt_key: @@ -66,20 +66,20 @@ # filename: samba-team # when: "'4.22.4' in samba_version.stdout" -- name: Update APT cache (only if upgrade is needed) - ansible.builtin.apt: - update_cache: yes - when: "'4.22.4' in samba_version.stdout" +# - name: Update APT cache (only if upgrade is needed) +# ansible.builtin.apt: +# update_cache: yes +# when: "'4.22.4' in samba_version.stdout" -- name: Upgrade Samba packages if version is 4.22.4 - ansible.builtin.apt: - name: - - samba - - samba-dsdb-modules - - samba-common-bin - - python3-samba - state: latest - when: "'4.22.4' in samba_version.stdout" +# - name: Upgrade Samba packages if version is 4.22.4 +# ansible.builtin.apt: +# name: +# - samba +# - samba-dsdb-modules +# - samba-common-bin +# - python3-samba +# state: latest +# when: "'4.22.4' in samba_version.stdout" - name: Verify installed Samba version ansible.builtin.command: samba --version