Refactored the main.yml file to improve organization and clarity. Renamed some tasks to follow a more consistent naming convention, making it easier to understand the flow of the setup process.
Updated the community.general.expect and ansible.builtin.expect modules to use the correct Ansible modules, improving code readability and maintainability. This change ensures that the expected output is properly handled and reduces the risk of errors.
This commit updates the Samba configuration to create and verify a reverse DNS zone, PTR record, and Kerberos authentication. The changes include updating debug messages and adding new tasks to verify the setup.
Updated the 'name' section of the verify.yml file to include a comment explaining the purpose of creating the reverse DNS zone, making it easier to understand and maintain.
Updated the 'name' field in the 'tasks/verify.yml' file to include quotes around the variable {{ addc_reverse_zone_name }} for proper formatting. This change ensures consistent and readable documentation.
Updated the 'create reverse dns zone' task with correct quotes around variable names, ensuring proper formatting and readability of the Ansible playbook.
Changed the `copy` task in kerberos.yml to use a remote source for the krb5 configuration file, allowing for easier management of the file on remote hosts.
Updated the regex pattern to correctly extract private/krb5.conf paths from the samba provision output, ensuring accurate configuration file detection.
Updated regular expressions in the `kerberos.yml` file to correctly extract and format Kerberos configuration paths, ensuring consistency and accuracy in the Ansible playbook.
Updated the Ansible playbook to validate the presence of the krb5.conf file, extract its path, and display it in a debug message. Additionally, added checks for the file's existence on disk and its contents to ensure proper Kerberos configuration.
Updated the regular expression to correctly extract the absolute path of the krb5.conf file from the samba provision output, removing unnecessary quotes and commas.
Updated the regular expression to correctly extract the absolute path of the krb5.conf file from the samba provision output. This change ensures that the extracted path is properly formatted and can be used in subsequent tasks.
Updated the regular expression to correctly extract the krb5.conf path from the Samba provision output, ensuring consistency in the configuration file location.
Updated the regular expression to extract the absolute path of the krb5.conf file from the samba provision output, ensuring a more accurate and reliable value.
Updated the regular expression to correctly extract the krb5.conf path from the Samba provision output. This change ensures that the correct path is used for setting the krb5_conf_path fact.
Updated the regex pattern to correctly extract the krb5.conf path from the Samba provision output. This change ensures that the variable returns a list of paths even if only one is present.
Updated the regex pattern to correctly extract the krb5.conf path from the `your_string_variable` value, ensuring a more reliable and consistent configuration setup.
Updated the regex search pattern in the `krb5_conf_path` fact to ensure a list is returned even if no match is found, and added default values for clarity.
Updated the regular expression to extract the absolute path of the krb5.conf file from the provision output, ensuring consistency and accuracy in the extracted value.
Updated the setup of DNS resolver and Kerberos configuration to ensure proper domain authentication. This change will improve the overall security of the system.
Enhanced the provision.yml to properly stop and mask regular Samba services, while unmasking and enabling the Samba AD/DC service. This ensures a more robust setup for the domain controller.
Renamed debug block to use Ansible debug output, removing unnecessary variables and improving readability. This change aims to make the code more maintainable and efficient.
Updated the Ansible playbook to correctly detect the Samba version and perform an upgrade if necessary. The changes also include adding the Samba Team Debian GPG key, repository, and updating the APT cache.
Updated the Samba Team Debian repository URL to use the modern method, which includes a signed-by keyring. This change improves security and stability of the package installation process.
Updated the URL for the Samba Team Debian GPG key to use a more reliable source, ensuring future installations can correctly verify the team's identity.
Updated the Ansible playbook to use modern methods for adding the Samba Team Debian GPG key and repository, making it easier to upgrade to a newer version of Samba. This change also includes updating the APT cache when an upgrade is needed.
Refactored the `tasks/preparing.yml` file to improve its structure, readability, and consistency with best practices. This includes updating variable names, adding whitespace, and standardizing indentation.
Prevents potential conflicts during the installation process by stopping Samba services before provisioning. This ensures a smoother and more reliable setup. The new step is added at line 74 of tasks/install.yml.
Fixed a typo in the debug message, updating it to use the correct variable `samba_domain_info.adminpass` instead of `addc_admin_password`. This ensures accurate output and prevents potential errors. The updated code will now correctly display the admin password for Samba AD DC.
Updated the debug message to include a new variable, allowing for more flexibility in the output. This change improves the readability and maintainability of the Ansible playbook.
Added a debug message to the Ansible playbook to display the admin password from the Samba domain, allowing for easier testing and debugging of the Samba AD DC setup.
Updated the admin password variable in the provision.yml file to use a dynamically generated value, making it easier to manage and update passwords across different environments.
Added a new task to stop relevant Samba services before provisioning, ensuring a clean environment for the AD DC setup. This change improves the overall stability and reliability of the provisioning process.
Updated the service configuration to ensure proper stopping of samba-ad-dc before provisioning, improving overall installation stability and consistency.
Updated the Ansible playbook to use apt instead of package for installing samba packages, adding additional options for improved efficiency and cleanup.
