[core]: switch all base_settings to variables

2025-09-13 07:10:51 +02:00 · 2025-09-08 13:56:41 +02:00
9 changed files with 199 additions and 208 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,23 +10,14 @@
 > [!CAUTION]
 Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit the project's popularity for potentially malicious purposes.

-## 2025-09-09
-
 ## 2025-09-08

 ### 🚀 Updated Scripts

  - #### 🐞 Bug Fixes

-    - CT's: fix missing variable declaration (actualBudget, openziti, umlautadaptarr) [@MickLesk](https://github.com/MickLesk) ([#7483](https://github.com/community-scripts/ProxmoxVE/pull/7483))
-    - karakeep: fix service file [@CrazyWolf13](https://github.com/CrazyWolf13) ([#7482](https://github.com/community-scripts/ProxmoxVE/pull/7482))
    - Update searxng-install.sh [@sebguy](https://github.com/sebguy) ([#7469](https://github.com/community-scripts/ProxmoxVE/pull/7469))

-  - #### ✨ New Features
-
-    - Immich: bump to version 1.141.1 [@vhsdream](https://github.com/vhsdream) ([#7418](https://github.com/community-scripts/ProxmoxVE/pull/7418))
-    - [core]: switch all base_settings to variables [@MickLesk](https://github.com/MickLesk) ([#7479](https://github.com/community-scripts/ProxmoxVE/pull/7479))
-
  - #### 💥 Breaking Changes

    - RustDesk Server: Update the credentials info [@tremor021](https://github.com/tremor021) ([#7473](https://github.com/community-scripts/ProxmoxVE/pull/7473))
--- a/ct/actualbudget.sh
+++ b/ct/actualbudget.sh
@@ -6,13 +6,13 @@ source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxV
 # Source: https://actualbudget.org/

 APP="Actual Budget"
-var_tags="${var_tags:-finance}"
-var_cpu="${var_cpu:-2}"
-var_ram="${var_ram:-2048}"
-var_disk="${var_disk:-4}"
-var_os="${var_os:-debian}"
-var_version="${var_version:-12}"
-var_unprivileged="${var_unprivileged:-1}"
+var_tags="finance"
+var_cpu="2"
+var_ram="2048"
+var_disk="4"
+var_os="debian"
+var_version="12"
+var_unprivileged="1"

 header_info "$APP"
 variables
--- a/ct/immich.sh
+++ b/ct/immich.sh
@@ -61,7 +61,7 @@ function update_script() {
    done
    msg_ok "Image-processing libraries up to date"
  fi
-  RELEASE="1.141.1"
+  RELEASE="1.140.1"
  if check_for_gh_release "immich" "immich-app/immich" "${RELEASE}"; then
    msg_info "Stopping Services"
    systemctl stop immich-web
--- a/ct/openziti-controller.sh
+++ b/ct/openziti-controller.sh
@@ -6,13 +6,13 @@ source <(curl -s https://raw.githubusercontent.com/community-scripts/ProxmoxVE/m
 # Source: https://github.com/openziti/ziti

 APP="openziti-controller"
-var_tags="${var_tags:-network;openziti-controller}"
-var_cpu="${var_cpu:-2}"
-var_ram="${var_ram:-1024}"
-var_disk="${var_disk:-8}"
-var_os="${var_os:-debian}"
-var_version="${var_version:-12}"
-var_unprivileged="${var_unprivileged:-1}"
+var_tags="network;openziti-controller"
+var_cpu="2"
+var_ram="1024"
+var_disk="8"
+var_os="debian"
+var_version="12"
+var_unprivileged="1"

 header_info "$APP"
 variables
@@ -20,18 +20,18 @@ color
 catch_errors

 function update_script() {
-  header_info
-  check_container_storage
-  check_container_resources
-  if [[ ! -d /opt/openziti ]]; then
-    msg_error "No ${APP} Installation Found!"
-    exit
-  fi
-  msg_info "Updating $APP LXC"
-  $STD apt-get update
-  $STD apt-get -y upgrade
-  msg_ok "Updated $APP LXC"
-  exit
+   header_info
+   check_container_storage
+   check_container_resources
+   if [[ ! -d /opt/openziti ]]; then
+      msg_error "No ${APP} Installation Found!"
+      exit
+   fi
+   msg_info "Updating $APP LXC"
+   $STD apt-get update
+   $STD apt-get -y upgrade
+   msg_ok "Updated $APP LXC"
+   exit
 }

 start
@@ -41,4 +41,4 @@ description
 msg_ok "Completed Successfully!\n"
 echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}"
 echo -e "${INFO}${YW} Access it using the following URL:${CL}"
-echo -e "${TAB}${GATEWAY}${BGN}https://${IP}:<port>/zac${CL}"
+echo -e "${TAB}${GATEWAY}${BGN}https://${IP}:<port>/zac${CL}"
--- a/ct/umlautadaptarr.sh
+++ b/ct/umlautadaptarr.sh
@@ -6,13 +6,13 @@ source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxV
 # Source: https://github.com/PCJones/UmlautAdaptarr

 APP="UmlautAdaptarr"
-var_tags="${var_tags:-arr}"
-var_cpu="${var_cpu:-1}"
-var_ram="${var_ram:-512}"
-var_disk="${var_disk:-4}"
-var_os="${var_os:-debian}"
-var_version="${var_version:-12}"
-var_unprivileged="${var_unprivileged:-1}"
+var_tags="arr"
+var_cpu="1"
+var_ram="512"
+var_disk="4"
+var_os="debian"
+var_version="12"
+var_unprivileged="1"

 header_info "$APP"
 variables
@@ -20,33 +20,33 @@ color
 catch_errors

 function update_script() {
-  header_info
-  check_container_storage
-  check_container_resources
-  if [[ ! -d /opt/UmlautAdaptarr ]]; then
-    msg_error "No ${APP} Installation Found!"
+    header_info
+    check_container_storage
+    check_container_resources
+    if [[ ! -d /opt/UmlautAdaptarr ]]; then
+        msg_error "No ${APP} Installation Found!"
+        exit
+    fi
+    RELEASE=$(curl -fsSL https://api.github.com/repos/PCJones/Umlautadaptarr/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3)}')
+    if [[ ! -f /opt/UmlautAdaptarr_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/UmlautAdaptarr_version.txt)" ]]; then
+        msg_info "Stopping Service"
+        systemctl stop umlautadaptarr
+        msg_ok "Stopped Service"
+
+        msg_info "Updating ${APP}"
+        temp_file=$(mktemp)
+        curl -fsSL "https://github.com/PCJones/Umlautadaptarr/releases/download/${RELEASE}/linux-x64.zip" -o $temp_file
+        $STD unzip -u $temp_file '*/**' -d /opt/UmlautAdaptarr
+        msg_ok "Updated ${APP}"
+
+        msg_info "Starting Service"
+        systemctl start umlautadaptarr
+        msg_ok "Started Service"
+        msg_ok "$APP has been updated to ${RELEASE}."
+    else
+        msg_ok "No update required. ${APP} is already at ${RELEASE}"
+    fi
    exit
-  fi
-  RELEASE=$(curl -fsSL https://api.github.com/repos/PCJones/Umlautadaptarr/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3)}')
-  if [[ ! -f /opt/UmlautAdaptarr_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/UmlautAdaptarr_version.txt)" ]]; then
-    msg_info "Stopping Service"
-    systemctl stop umlautadaptarr
-    msg_ok "Stopped Service"
-
-    msg_info "Updating ${APP}"
-    temp_file=$(mktemp)
-    curl -fsSL "https://github.com/PCJones/Umlautadaptarr/releases/download/${RELEASE}/linux-x64.zip" -o $temp_file
-    $STD unzip -u $temp_file '*/**' -d /opt/UmlautAdaptarr
-    msg_ok "Updated ${APP}"
-
-    msg_info "Starting Service"
-    systemctl start umlautadaptarr
-    msg_ok "Started Service"
-    msg_ok "$APP has been updated to ${RELEASE}."
-  else
-    msg_ok "No update required. ${APP} is already at ${RELEASE}"
-  fi
-  exit
 }
 start
 build_container
--- a/frontend/public/json/versions.json
+++ b/frontend/public/json/versions.json
@@ -1,144 +1,14 @@
 [
  {
-    "name": "YunoHost/yunohost",
-    "version": "debian/12.1.20",
-    "date": "2025-09-08T23:47:21Z"
-  },
-  {
-    "name": "mongodb/mongo",
-    "version": "r8.0.14-rc1",
-    "date": "2025-09-08T22:50:53Z"
-  },
-  {
-    "name": "diced/zipline",
-    "version": "v4.3.1",
-    "date": "2025-09-08T22:26:23Z"
-  },
-  {
-    "name": "cross-seed/cross-seed",
-    "version": "v6.13.3",
-    "date": "2025-09-08T21:45:15Z"
-  },
-  {
-    "name": "HabitRPG/habitica",
-    "version": "v5.40.2",
-    "date": "2025-09-08T20:59:44Z"
-  },
-  {
-    "name": "booklore-app/booklore",
-    "version": "v1.2.1",
-    "date": "2025-09-08T19:31:07Z"
-  },
-  {
-    "name": "mattermost/mattermost",
-    "version": "server/public/v0.1.18",
-    "date": "2025-09-08T18:04:10Z"
-  },
-  {
-    "name": "immich-app/immich",
-    "version": "v1.141.1",
-    "date": "2025-09-08T17:15:33Z"
-  },
-  {
-    "name": "msgbyte/tianji",
-    "version": "v1.24.27",
-    "date": "2025-09-08T16:23:37Z"
-  },
-  {
-    "name": "Paymenter/Paymenter",
-    "version": "v1.3.1",
-    "date": "2025-09-08T15:26:01Z"
-  },
-  {
-    "name": "n8n-io/n8n",
-    "version": "n8n@1.109.2",
-    "date": "2025-09-03T07:50:21Z"
-  },
-  {
-    "name": "apache/tomcat",
-    "version": "10.1.46",
-    "date": "2025-09-08T14:29:54Z"
-  },
-  {
-    "name": "home-assistant/operating-system",
-    "version": "16.2",
-    "date": "2025-09-08T14:03:25Z"
-  },
-  {
-    "name": "zitadel/zitadel",
-    "version": "v4.1.3",
-    "date": "2025-09-08T13:36:08Z"
-  },
-  {
-    "name": "theonedev/onedev",
-    "version": "v12.0.10",
-    "date": "2025-09-08T13:20:16Z"
-  },
-  {
-    "name": "evcc-io/evcc",
-    "version": "0.207.6",
-    "date": "2025-09-08T11:52:00Z"
-  },
-  {
-    "name": "autobrr/autobrr",
-    "version": "v1.66.1",
-    "date": "2025-09-08T10:49:03Z"
-  },
-  {
-    "name": "meilisearch/meilisearch",
-    "version": "latest",
-    "date": "2025-09-08T10:03:11Z"
-  },
-  {
-    "name": "syncthing/syncthing",
-    "version": "v2.0.8",
-    "date": "2025-09-08T08:07:18Z"
-  },
-  {
-    "name": "nzbgetcom/nzbget",
-    "version": "v25.3",
-    "date": "2025-09-01T09:47:06Z"
-  },
-  {
-    "name": "TandoorRecipes/recipes",
-    "version": "2.1.1",
-    "date": "2025-09-08T06:39:30Z"
-  },
-  {
-    "name": "firefly-iii/firefly-iii",
-    "version": "v6.3.2",
-    "date": "2025-08-19T04:08:36Z"
-  },
-  {
-    "name": "Jackett/Jackett",
-    "version": "v0.22.2441",
-    "date": "2025-09-08T06:01:57Z"
-  },
-  {
-    "name": "webmin/webmin",
-    "version": "2.501",
-    "date": "2025-09-08T04:50:25Z"
-  },
-  {
-    "name": "jeedom/core",
-    "version": "4.4.19",
-    "date": "2025-09-08T00:27:05Z"
-  },
-  {
-    "name": "steveiliop56/tinyauth",
-    "version": "v3.6.2",
-    "date": "2025-07-17T12:08:03Z"
+    "name": "9001/copyparty",
+    "version": "v1.19.8",
+    "date": "2025-09-07T23:36:42Z"
  },
  {
    "name": "paperless-ngx/paperless-ngx",
    "version": "v2.18.4",
    "date": "2025-09-07T23:57:32Z"
  },
-  {
-    "name": "9001/copyparty",
-    "version": "v1.19.8",
-    "date": "2025-09-07T23:36:42Z"
-  },
  {
    "name": "Part-DB/Part-DB-server",
    "version": "v2.1.1",
@@ -164,16 +34,31 @@
    "version": "0.50.12",
    "date": "2025-09-07T14:16:07Z"
  },
+  {
+    "name": "cross-seed/cross-seed",
+    "version": "v6.13.2",
+    "date": "2025-08-19T18:18:40Z"
+  },
+  {
+    "name": "firefly-iii/firefly-iii",
+    "version": "v6.3.2",
+    "date": "2025-08-19T04:08:36Z"
+  },
  {
    "name": "runtipi/runtipi",
    "version": "nightly",
-    "date": "2025-09-07T12:25:06Z"
+    "date": "2025-09-07T12:16:33Z"
  },
  {
    "name": "semaphoreui/semaphore",
    "version": "v2.17.0-beta1",
    "date": "2025-09-07T08:56:50Z"
  },
+  {
+    "name": "Jackett/Jackett",
+    "version": "v0.22.2438",
+    "date": "2025-09-07T06:00:21Z"
+  },
  {
    "name": "Radarr/Radarr",
    "version": "v5.27.5.10198",
@@ -194,6 +79,16 @@
    "version": "v2.13.3.4711",
    "date": "2025-08-28T20:06:24Z"
  },
+  {
+    "name": "jeedom/core",
+    "version": "4.4.19",
+    "date": "2025-09-07T00:27:07Z"
+  },
+  {
+    "name": "steveiliop56/tinyauth",
+    "version": "v3.6.2",
+    "date": "2025-07-17T12:08:03Z"
+  },
  {
    "name": "rcourtman/Pulse",
    "version": "v4.14.0",
@@ -204,11 +99,21 @@
    "version": "v1.6.4",
    "date": "2025-08-18T20:22:07Z"
  },
+  {
+    "name": "autobrr/autobrr",
+    "version": "v1.66.0",
+    "date": "2025-09-06T15:07:16Z"
+  },
  {
    "name": "fuma-nama/fumadocs",
    "version": "create-fumadocs-app@15.7.10",
    "date": "2025-09-06T10:13:43Z"
  },
+  {
+    "name": "Paymenter/Paymenter",
+    "version": "v1.3.0",
+    "date": "2025-09-06T09:02:08Z"
+  },
  {
    "name": "Luligu/matterbridge",
    "version": "3.2.6",
@@ -219,6 +124,11 @@
    "version": "v12.0.3",
    "date": "2025-09-06T07:01:44Z"
  },
+  {
+    "name": "theonedev/onedev",
+    "version": "v12.0.9",
+    "date": "2025-09-06T00:39:00Z"
+  },
  {
    "name": "moghtech/komodo",
    "version": "v1.19.3",
@@ -229,6 +139,16 @@
    "version": "v1.36.1",
    "date": "2025-09-05T21:14:40Z"
  },
+  {
+    "name": "booklore-app/booklore",
+    "version": "v1.2.0",
+    "date": "2025-09-05T20:43:03Z"
+  },
+  {
+    "name": "immich-app/immich",
+    "version": "v1.141.1",
+    "date": "2025-09-05T19:44:39Z"
+  },
  {
    "name": "gtsteffaniak/filebrowser",
    "version": "v0.8.4-beta",
@@ -239,6 +159,11 @@
    "version": "v1.3.2",
    "date": "2025-09-05T18:44:15Z"
  },
+  {
+    "name": "diced/zipline",
+    "version": "v4.3.0",
+    "date": "2025-09-05T18:43:28Z"
+  },
  {
    "name": "henrygd/beszel",
    "version": "v0.12.7",
@@ -269,6 +194,16 @@
    "version": "2025.9.1",
    "date": "2025-09-05T11:15:21Z"
  },
+  {
+    "name": "syncthing/syncthing",
+    "version": "v2.0.7",
+    "date": "2025-09-05T10:18:24Z"
+  },
+  {
+    "name": "zitadel/zitadel",
+    "version": "v4.1.2",
+    "date": "2025-09-05T08:23:30Z"
+  },
  {
    "name": "CrazyWolf13/streamlink-webui",
    "version": "0.6",
@@ -299,16 +234,36 @@
    "version": "v1.0.0-beta17",
    "date": "2025-09-04T21:30:14Z"
  },
+  {
+    "name": "TandoorRecipes/recipes",
+    "version": "2.1.0",
+    "date": "2025-09-04T20:24:47Z"
+  },
+  {
+    "name": "mongodb/mongo",
+    "version": "r7.0.24",
+    "date": "2025-09-04T19:50:49Z"
+  },
  {
    "name": "Cleanuparr/Cleanuparr",
    "version": "v2.2.3",
    "date": "2025-09-04T19:24:39Z"
  },
+  {
+    "name": "HabitRPG/habitica",
+    "version": "v5.40.1",
+    "date": "2025-09-04T19:10:45Z"
+  },
  {
    "name": "AdguardTeam/AdGuardHome",
    "version": "v0.107.65",
    "date": "2025-08-20T14:02:28Z"
  },
+  {
+    "name": "webmin/webmin",
+    "version": "2.500",
+    "date": "2025-09-04T17:44:27Z"
+  },
  {
    "name": "ollama/ollama",
    "version": "v0.11.10",
@@ -384,11 +339,21 @@
    "version": "5.26.12",
    "date": "2025-09-03T12:03:22Z"
  },
+  {
+    "name": "n8n-io/n8n",
+    "version": "n8n@1.109.2",
+    "date": "2025-09-03T07:50:21Z"
+  },
  {
    "name": "Checkmk/checkmk",
    "version": "v2.4.0p11",
    "date": "2025-09-03T09:58:14Z"
  },
+  {
+    "name": "mattermost/mattermost",
+    "version": "server/public/v0.1.17",
+    "date": "2025-09-02T21:38:40Z"
+  },
  {
    "name": "cockpit-project/cockpit",
    "version": "346",
@@ -424,6 +389,11 @@
    "version": "v4.1.4",
    "date": "2025-09-02T14:26:24Z"
  },
+  {
+    "name": "apache/tomcat",
+    "version": "10.1.45",
+    "date": "2025-09-02T12:46:34Z"
+  },
  {
    "name": "Dolibarr/dolibarr",
    "version": "22.0.1",
@@ -464,6 +434,11 @@
    "version": "v0.87.3",
    "date": "2025-09-01T16:25:43Z"
  },
+  {
+    "name": "home-assistant/operating-system",
+    "version": "16.1",
+    "date": "2025-08-13T07:58:10Z"
+  },
  {
    "name": "seanmorley15/AdventureLog",
    "version": "v0.11.0",
@@ -479,6 +454,11 @@
    "version": "preview-issue-description",
    "date": "2025-09-01T12:21:58Z"
  },
+  {
+    "name": "nzbgetcom/nzbget",
+    "version": "v25.3",
+    "date": "2025-09-01T09:47:06Z"
+  },
  {
    "name": "grokability/snipe-it",
    "version": "v8.3.1",
@@ -494,6 +474,11 @@
    "version": "0.20.1",
    "date": "2025-09-01T07:35:48Z"
  },
+  {
+    "name": "YunoHost/yunohost",
+    "version": "debian/12.1.17.1",
+    "date": "2025-08-31T21:38:21Z"
+  },
  {
    "name": "LibreTranslate/LibreTranslate",
    "version": "v1.7.3",
@@ -504,6 +489,11 @@
    "version": "v0.9.91",
    "date": "2025-08-30T21:49:57Z"
  },
+  {
+    "name": "msgbyte/tianji",
+    "version": "v1.24.26",
+    "date": "2025-08-29T20:26:08Z"
+  },
  {
    "name": "silverbulletmd/silverbullet",
    "version": "2.0.0",
@@ -584,6 +574,16 @@
    "version": "v3.5.1",
    "date": "2025-08-27T09:21:19Z"
  },
+  {
+    "name": "meilisearch/meilisearch",
+    "version": "latest",
+    "date": "2025-08-26T14:14:42Z"
+  },
+  {
+    "name": "evcc-io/evcc",
+    "version": "0.207.5",
+    "date": "2025-08-26T06:57:07Z"
+  },
  {
    "name": "documenso/documenso",
    "version": "v1.12.2-rc.6",
--- a/install/immich-install.sh
+++ b/install/immich-install.sh
@@ -285,7 +285,7 @@ GEO_DIR="${INSTALL_DIR}/geodata"
 mkdir -p "$INSTALL_DIR"
 mkdir -p {"${APP_DIR}","${UPLOAD_DIR}","${GEO_DIR}","${INSTALL_DIR}"/cache}

-fetch_and_deploy_gh_release "immich" "immich-app/immich" "tarball" "v1.141.1" "$SRC_DIR"
+fetch_and_deploy_gh_release "immich" "immich-app/immich" "tarball" "v1.140.1" "$SRC_DIR"

 msg_info "Installing ${APPLICATION} (more patience please)"

--- a/install/karakeep-install.sh
+++ b/install/karakeep-install.sh
@@ -158,7 +158,7 @@ Wants=network.target karakeep-browser.service meilisearch.service
 After=network.target karakeep-browser.service meilisearch.service

 [Service]
-ExecStart=/usr/bin/node dist/index.js
+ExecStart=/usr/bin/node dist/index.mjs
 WorkingDirectory=/opt/karakeep/apps/workers
 EnvironmentFile=/etc/karakeep/karakeep.env
 Restart=always
--- a/misc/build.func
+++ b/misc/build.func
@@ -26,7 +26,7 @@ elif command -v wget >/dev/null 2>&1; then
 fi
 # This function enables error handling in the script by setting options and defining a trap for the ERR signal.
 catch_errors() {
-  set -Eeo pipefail
+  set -Eeuo pipefail
  trap 'error_handler $LINENO "$BASH_COMMAND"' ERR
 }

@@ -346,7 +346,7 @@ echo_default() {
  echo -e "${DISKSIZE}${BOLD}${DGN}Disk Size: ${BGN}${DISK_SIZE} GB${CL}"
  echo -e "${CPUCORE}${BOLD}${DGN}CPU Cores: ${BGN}${CORE_COUNT}${CL}"
  echo -e "${RAMSIZE}${BOLD}${DGN}RAM Size: ${BGN}${RAM_SIZE} MiB${CL}"
-  if [ "$VERBOSE" == "yes" ]; then
+  if [ "$VERB" == "yes" ]; then
    echo -e "${SEARCH}${BOLD}${DGN}Verbose Mode: ${BGN}Enabled${CL}"
  fi
  echo -e "${CREATING}${BOLD}${BL}Creating a ${APP} LXC using the above default settings${CL}"