fix: pmg - split no-nag script into separate config files

The subscription nag disabling logic is now written to two distinct apt config files, one for proxmoxlib.js and one for pmgmanagerlib-mobile.js, fixing issue #7416
Update CHANGELOG.md (#7536 )
2025-09-13 07:10:51 +02:00 · 2025-09-10 11:49:31 +02:00 · 2025-09-10 07:44:30 +00:00 · 2025-09-10 09:44:09 +02:00 · 2025-09-10 07:15:02 +00:00 · 2025-09-10 09:14:41 +02:00
37 changed files with 81 additions and 50 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,22 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

 ## 2025-09-10

+### 🚀 Updated Scripts
+
+  - #### ✨ New Features
+
+    - Booklore: Add Bookdrop location to .env [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#7533](https://github.com/community-scripts/ProxmoxVE/pull/7533))
+
+  - #### 🔧 Refactor
+
+    - Improve npmplus credential retrieval and messaging [@MickLesk](https://github.com/MickLesk) ([#7532](https://github.com/community-scripts/ProxmoxVE/pull/7532))
+
+### 🌐 Website
+
+  - #### 📝 Script Information
+
+    - set updateable to true for several lxc JSON-configs [@MickLesk](https://github.com/MickLesk) ([#7534](https://github.com/community-scripts/ProxmoxVE/pull/7534))
+
 ## 2025-09-09

 ### 🚀 Updated Scripts
--- a/frontend/public/json/add-netbird-lxc.json
+++ b/frontend/public/json/add-netbird-lxc.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-19",
  "type": "addon",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": null,
  "documentation": "https://docs.netbird.io/",
--- a/frontend/public/json/add-tailscale-lxc.json
+++ b/frontend/public/json/add-tailscale-lxc.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "addon",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": null,
  "documentation": "https://tailscale.com/kb/1017/install",
--- a/frontend/public/json/apt-cacher-ng.json
+++ b/frontend/public/json/apt-cacher-ng.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 3142,
  "documentation": "https://www.unix-ag.uni-kl.de/~bloch/acng/html/index.html",
--- a/frontend/public/json/beszel.json
+++ b/frontend/public/json/beszel.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2025-01-20",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8090,
  "documentation": "https://beszel.dev/guide/what-is-beszel",
--- a/frontend/public/json/cloudflare-ddns.json
+++ b/frontend/public/json/cloudflare-ddns.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2025-05-22",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": null,
  "documentation": "https://github.com/favonia/cloudflare-ddns/blob/main/README.markdown",
--- a/frontend/public/json/cloudflared.json
+++ b/frontend/public/json/cloudflared.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": null,
  "documentation": "https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/",
--- a/frontend/public/json/dashy.json
+++ b/frontend/public/json/dashy.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 4000,
  "documentation": "https://dashy.to/docs",
--- a/frontend/public/json/deconz.json
+++ b/frontend/public/json/deconz.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": true,
  "interface_port": 80,
  "documentation": "https://github.com/dresden-elektronik/deconz-rest-plugin/wiki",
--- a/frontend/public/json/deluge.json
+++ b/frontend/public/json/deluge.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8112,
  "documentation": "https://www.deluge-torrent.org/userguide/",
--- a/frontend/public/json/fhem.json
+++ b/frontend/public/json/fhem.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8083,
  "documentation": "https://fhem.de/#Documentation",
--- a/frontend/public/json/filebrowser-quantum.json
+++ b/frontend/public/json/filebrowser-quantum.json
@@ -7,7 +7,7 @@
  ],
  "date_created": "2025-06-18",
  "type": "addon",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8080,
  "documentation": "https://github.com/gtsteffaniak/filebrowser/wiki/Getting-Started",
--- a/frontend/public/json/filebrowser.json
+++ b/frontend/public/json/filebrowser.json
@@ -7,7 +7,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "addon",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8080,
  "documentation": null,
--- a/frontend/public/json/homebridge.json
+++ b/frontend/public/json/homebridge.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8581,
  "documentation": "https://github.com/homebridge/homebridge/wiki",
--- a/frontend/public/json/hyperhdr.json
+++ b/frontend/public/json/hyperhdr.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": true,
  "interface_port": 8090,
  "documentation": "https://github.com/awawa-dev/HyperHDR/wiki",
--- a/frontend/public/json/influxdb.json
+++ b/frontend/public/json/influxdb.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8086,
  "documentation": "https://docs.influxdata.com/",
--- a/frontend/public/json/jeedom.json
+++ b/frontend/public/json/jeedom.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2025-07-29",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 80,
  "documentation": "https://doc.jeedom.com",
--- a/frontend/public/json/jenkins.json
+++ b/frontend/public/json/jenkins.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-12-26",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8080,
  "documentation": "https://www.jenkins.io/doc/",
--- a/frontend/public/json/lazylibrarian.json
+++ b/frontend/public/json/lazylibrarian.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 5299,
  "documentation": "https://lazylibrarian.gitlab.io/lazylibrarian.gitlab.io/",
--- a/frontend/public/json/lldap.json
+++ b/frontend/public/json/lldap.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-08-06",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 17170,
  "documentation": "https://github.com/lldap/lldap/blob/main/README.md",
--- a/frontend/public/json/mariadb.json
+++ b/frontend/public/json/mariadb.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 3306,
  "documentation": "https://github.com/community-scripts/ProxmoxVE/discussions/192",
--- a/frontend/public/json/mattermost.json
+++ b/frontend/public/json/mattermost.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2025-01-30",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8065,
  "documentation": "https://docs.mattermost.com/",
--- a/frontend/public/json/mongodb.json
+++ b/frontend/public/json/mongodb.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-18",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 27017,
  "documentation": "https://www.mongodb.com/docs/manual/",
--- a/frontend/public/json/mqtt.json
+++ b/frontend/public/json/mqtt.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": null,
  "documentation": "https://mosquitto.org/documentation/",
--- a/frontend/public/json/npmplus.json
+++ b/frontend/public/json/npmplus.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2025-03-13",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 81,
  "documentation": "https://github.com/ZoeyVid/NPMplus/blob/develop/README.md",
@@ -39,7 +39,7 @@
    }
  ],
  "default_credentials": {
-    "username": "root",
+    "username": "admin@example.org",
    "password": null
  },
  "notes": [
@@ -52,7 +52,7 @@
      "type": "info"
    },
    {
-      "text": "Application credentials: `cat /opt/.npm_pwd`",
+      "text": "Application credentials: `cat /opt/.npm_pwd` - if file not exist in LXC check docker logs for password with `docker logs npmplus`",
      "type": "info"
    }
  ]
--- a/frontend/public/json/ntfy.json
+++ b/frontend/public/json/ntfy.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 80,
  "documentation": "https://docs.ntfy.sh/",
--- a/frontend/public/json/omv.json
+++ b/frontend/public/json/omv.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 80,
  "documentation": "https://docs.openmediavault.org/en/stable/",
--- a/frontend/public/json/openhab.json
+++ b/frontend/public/json/openhab.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8443,
  "documentation": "https://www.openhab.org/docs/",
--- a/frontend/public/json/pialert.json
+++ b/frontend/public/json/pialert.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": null,
  "documentation": "https://github.com/leiweibau/Pi.Alert/blob/main/README.md",
--- a/frontend/public/json/radicale.json
+++ b/frontend/public/json/radicale.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2025-02-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 5232,
  "documentation": "https://radicale.org/master.html#documentation-1",
--- a/frontend/public/json/smokeping.json
+++ b/frontend/public/json/smokeping.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": null,
  "documentation": "https://oss.oetiker.ch/smokeping/doc/index.en.html",
--- a/frontend/public/json/syncthing.json
+++ b/frontend/public/json/syncthing.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8384,
  "documentation": "https://docs.syncthing.net/",
--- a/frontend/public/json/tautulli.json
+++ b/frontend/public/json/tautulli.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8181,
  "documentation": "https://github.com/Tautulli/Tautulli/wiki",
--- a/frontend/public/json/unifi.json
+++ b/frontend/public/json/unifi.json
@@ -6,7 +6,7 @@
  ],
  "date_created": "2024-05-02",
  "type": "ct",
-  "updateable": false,
+  "updateable": true,
  "privileged": false,
  "interface_port": 8443,
  "documentation": null,
--- a/install/booklore-install.sh
+++ b/install/booklore-install.sh
@@ -46,7 +46,7 @@ $STD npm run build --configuration=production
 msg_ok "Built Frontend"

 msg_info "Creating Environment"
-mkdir -p /opt/booklore_storage{/data,/books}
+mkdir -p /opt/booklore_storage{/data,/books,/bookdrop}
 cat <<EOF >/opt/booklore_storage/.env
 DATABASE_URL=jdbc:mariadb://localhost:3306/$DB_NAME
 DATABASE_USERNAME=$DB_USER
@@ -55,6 +55,7 @@ BOOKLORE_PORT=6060

 BOOKLORE_DATA_PATH=/opt/booklore_storage/data
 BOOKLORE_BOOKS_PATH=/opt/booklore_storage/books
+BOOKLORE_BOOKDROP_PATH=/opt/booklore_storage/bookdrop
 EOF
 msg_ok "Created Environment"

--- a/install/npmplus-install.sh
+++ b/install/npmplus-install.sh
@@ -89,19 +89,36 @@ customize

 msg_info "Retrieving Default Login (Patience)"
 PASSWORD_FOUND=0
+
 for i in {1..60}; do
-  PASSWORD_LINE=$(docker logs "$CONTAINER_ID" 2>&1 | awk '/Creating a new user:/ { print; exit }')
-  if [[ -n "$PASSWORD_LINE" ]]; then
-    PASSWORD=$(echo "$PASSWORD_LINE" | awk -F 'password: ' '{print $2}')
-    echo -e "username: admin@example.org\npassword: $PASSWORD" >/opt/.npm_pwd
+  PASSWORD_LINE=$(
+    { awk '/Creating a new user:/{print; exit}' < <(docker logs "$CONTAINER_ID" 2>&1); } || true
+  )
+
+  if [[ -n "${PASSWORD_LINE:-}" ]]; then
+    PASSWORD="${PASSWORD_LINE#*password: }"
+    printf 'username: admin@example.org\npassword: %s\n' "$PASSWORD" >/opt/.npm_pwd
    msg_ok "Saved default login to /opt/.npm_pwd"
    PASSWORD_FOUND=1
    break
  fi
  sleep 2
 done
+if [[ $PASSWORD_FOUND -eq 0 ]]; then
+  PASSWORD_LINE=$(
+    timeout 30s bash -c '
+      docker logs -f --since=0s --tail=0 "$1" 2>&1 | awk "/Creating a new user:/{print; exit}"
+    ' _ "$CONTAINER_ID" || true
+  )
+  if [[ -n "${PASSWORD_LINE:-}" ]]; then
+    PASSWORD="${PASSWORD_LINE#*password: }"
+    printf 'username: admin@example.org\npassword: %s\n' "$PASSWORD" >/opt/.npm_pwd
+    msg_ok "Saved default login to /opt/.npm_pwd (live)"
+    PASSWORD_FOUND=1
+  fi
+fi

 if [[ $PASSWORD_FOUND -eq 0 ]]; then
-  msg_error "Could not retrieve default login after 60 seconds."
+  msg_error "Could not retrieve default login after 120s."
  echo -e "\nYou can manually check the container logs with:\n  docker logs $CONTAINER_ID | grep 'Creating a new user:'\n"
 fi
--- a/tools/pve/post-pmg-install.sh
+++ b/tools/pve/post-pmg-install.sh
@@ -250,15 +250,12 @@ EOF
    whiptail --backtitle "Proxmox VE Helper Scripts" --msgbox --title "Support Subscriptions" \
      "Supporting the software's development team is essential.\nPlease consider buying a subscription." 10 58
    msg_info "Disabling subscription nag"
-    cat <<'EOF' >/etc/apt/apt.conf.d/no-nag-script
-DPkg::Post-Invoke {
-  "if [ -s /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js ] && ! grep -q -F 'NoMoreNagging' /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js; then
-     sed -i '/data\.status/{s/\\!//;s/active/NoMoreNagging/}' /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js;
-   fi";
-  "if [ -s /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js ] && ! grep -q -F 'NoMoreNagging' /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js; then
-     sed -i '/data\.status/{s/\\!//;s/active/NoMoreNagging/}' /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js;
-   fi";
-};
+    cat >/etc/apt/apt.conf.d/no-nag-script <<'EOF'
+DPkg::Post-Invoke { "if [ -s /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js ] && ! grep -q -F 'NoMoreNagging' /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js; then sed -i '/data\.status/{s/\!//;s/active/NoMoreNagging/}' /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js; fi"; };
+EOF
+
+    cat >/etc/apt/apt.conf.d/no-nag-script-pmgmanagerlib-mobile <<'EOF'
+DPkg::Post-Invoke { "if [ -s /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js ] && ! grep -q -F 'NoMoreNagging' /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js; then sed -i '/data\.status/{s/\!//;s/active/NoMoreNagging/}' /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js; fi"; };
 EOF
    msg_ok "Disabled subscription nag (clear browser cache!)"
    ;;
Author	SHA1	Message	Date
CanbiZ	c2e1e4a16a	fix: pmg - split no-nag script into separate config files The subscription nag disabling logic is now written to two distinct apt config files, one for proxmoxlib.js and one for pmgmanagerlib-mobile.js, fixing issue #7416	2025-09-10 11:49:31 +02:00
community-scripts-pr-app[bot]	63f6d772ea	Update CHANGELOG.md (#7536 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2025-09-10 07:44:30 +00:00
CanbiZ	652df1f370	Set updateable to true for all JSON app configs (#7534 )	2025-09-10 09:44:09 +02:00
community-scripts-pr-app[bot]	f4b5baf308	Update CHANGELOG.md (#7535 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2025-09-10 07:15:02 +00:00
Michel Roegl-Brunner	cc36fd5434	Booklore: Add Bookdrop location to .env (#7533 )	2025-09-10 09:14:41 +02:00
CanbiZ	3e182978ad	Improve npmplus credential retrieval and messaging (#7532 ) * Improve npmplus credential retrieval and messaging Enhanced the install script to attempt live log monitoring for credentials if not found initially, and updated the info message in npmplus.json to guide users to check docker logs if the credentials file is missing. * Update npmplus.json * Change updateable status to true in npmplus.json	2025-09-10 09:14:15 +02:00