CT's: fix missing variable declaration (actualBudget, openziti, umlautadaptarr)

Co-authored-by: GitHub Actions[bot] <github-actions[bot]@users.noreply.github.com>

CHANGELOG.md

@@ -18,6 +18,10 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
     - Update searxng-install.sh [@sebguy](https://github.com/sebguy) ([#7469](https://github.com/community-scripts/ProxmoxVE/pull/7469))
 
+  - #### ✨ New Features
+
+    - [core]: switch all base_settings to variables [@MickLesk](https://github.com/MickLesk) ([#7479](https://github.com/community-scripts/ProxmoxVE/pull/7479))
+
   - #### 💥 Breaking Changes
 
     - RustDesk Server: Update the credentials info [@tremor021](https://github.com/tremor021) ([#7473](https://github.com/community-scripts/ProxmoxVE/pull/7473))

ct/actualbudget.sh

@@ -6,13 +6,13 @@ source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxV
 # Source: https://actualbudget.org/
 
 APP="Actual Budget"
-var_tags="finance"
-var_cpu="2"
-var_ram="2048"
-var_disk="4"
-var_os="debian"
-var_version="12"
-var_unprivileged="1"
+var_tags="${var_tags:-finance}"
+var_cpu="${var_cpu:-2}"
+var_ram="${var_ram:-2048}"
+var_disk="${var_disk:-4}"
+var_os="${var_os:-debian}"
+var_version="${var_version:-12}"
+var_unprivileged="${var_unprivileged:-1}"
 
 header_info "$APP"
 variables

ct/openziti-controller.sh

@@ -6,13 +6,13 @@ source <(curl -s https://raw.githubusercontent.com/community-scripts/ProxmoxVE/m
 # Source: https://github.com/openziti/ziti
 
 APP="openziti-controller"
-var_tags="network;openziti-controller"
-var_cpu="2"
-var_ram="1024"
-var_disk="8"
-var_os="debian"
-var_version="12"
-var_unprivileged="1"
+var_tags="${var_tags:-network;openziti-controller}"
+var_cpu="${var_cpu:-2}"
+var_ram="${var_ram:-1024}"
+var_disk="${var_disk:-8}"
+var_os="${var_os:-debian}"
+var_version="${var_version:-12}"
+var_unprivileged="${var_unprivileged:-1}"
 
 header_info "$APP"
 variables
@@ -20,18 +20,18 @@ color
 catch_errors
 
 function update_script() {
-   header_info
-   check_container_storage
-   check_container_resources
-   if [[ ! -d /opt/openziti ]]; then
-      msg_error "No ${APP} Installation Found!"
-      exit
-   fi
-   msg_info "Updating $APP LXC"
-   $STD apt-get update
-   $STD apt-get -y upgrade
-   msg_ok "Updated $APP LXC"
-   exit
+  header_info
+  check_container_storage
+  check_container_resources
+  if [[ ! -d /opt/openziti ]]; then
+    msg_error "No ${APP} Installation Found!"
+    exit
+  fi
+  msg_info "Updating $APP LXC"
+  $STD apt-get update
+  $STD apt-get -y upgrade
+  msg_ok "Updated $APP LXC"
+  exit
 }
 
 start
@@ -41,4 +41,4 @@ description
 msg_ok "Completed Successfully!\n"
 echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}"
 echo -e "${INFO}${YW} Access it using the following URL:${CL}"
-echo -e "${TAB}${GATEWAY}${BGN}https://${IP}:<port>/zac${CL}"
+echo -e "${TAB}${GATEWAY}${BGN}https://${IP}:<port>/zac${CL}"

ct/umlautadaptarr.sh

@@ -6,13 +6,13 @@ source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxV
 # Source: https://github.com/PCJones/UmlautAdaptarr
 
 APP="UmlautAdaptarr"
-var_tags="arr"
-var_cpu="1"
-var_ram="512"
-var_disk="4"
-var_os="debian"
-var_version="12"
-var_unprivileged="1"
+var_tags="${var_tags:-arr}"
+var_cpu="${var_cpu:-1}"
+var_ram="${var_ram:-512}"
+var_disk="${var_disk:-4}"
+var_os="${var_os:-debian}"
+var_version="${var_version:-12}"
+var_unprivileged="${var_unprivileged:-1}"
 
 header_info "$APP"
 variables
@@ -20,33 +20,33 @@ color
 catch_errors
 
 function update_script() {
-    header_info
-    check_container_storage
-    check_container_resources
-    if [[ ! -d /opt/UmlautAdaptarr ]]; then
-        msg_error "No ${APP} Installation Found!"
-        exit
-    fi
-    RELEASE=$(curl -fsSL https://api.github.com/repos/PCJones/Umlautadaptarr/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3)}')
-    if [[ ! -f /opt/UmlautAdaptarr_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/UmlautAdaptarr_version.txt)" ]]; then
-        msg_info "Stopping Service"
-        systemctl stop umlautadaptarr
-        msg_ok "Stopped Service"
-
-        msg_info "Updating ${APP}"
-        temp_file=$(mktemp)
-        curl -fsSL "https://github.com/PCJones/Umlautadaptarr/releases/download/${RELEASE}/linux-x64.zip" -o $temp_file
-        $STD unzip -u $temp_file '*/**' -d /opt/UmlautAdaptarr
-        msg_ok "Updated ${APP}"
-
-        msg_info "Starting Service"
-        systemctl start umlautadaptarr
-        msg_ok "Started Service"
-        msg_ok "$APP has been updated to ${RELEASE}."
-    else
-        msg_ok "No update required. ${APP} is already at ${RELEASE}"
-    fi
+  header_info
+  check_container_storage
+  check_container_resources
+  if [[ ! -d /opt/UmlautAdaptarr ]]; then
+    msg_error "No ${APP} Installation Found!"
     exit
+  fi
+  RELEASE=$(curl -fsSL https://api.github.com/repos/PCJones/Umlautadaptarr/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3)}')
+  if [[ ! -f /opt/UmlautAdaptarr_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/UmlautAdaptarr_version.txt)" ]]; then
+    msg_info "Stopping Service"
+    systemctl stop umlautadaptarr
+    msg_ok "Stopped Service"
+
+    msg_info "Updating ${APP}"
+    temp_file=$(mktemp)
+    curl -fsSL "https://github.com/PCJones/Umlautadaptarr/releases/download/${RELEASE}/linux-x64.zip" -o $temp_file
+    $STD unzip -u $temp_file '*/**' -d /opt/UmlautAdaptarr
+    msg_ok "Updated ${APP}"
+
+    msg_info "Starting Service"
+    systemctl start umlautadaptarr
+    msg_ok "Started Service"
+    msg_ok "$APP has been updated to ${RELEASE}."
+  else
+    msg_ok "No update required. ${APP} is already at ${RELEASE}"
+  fi
+  exit
 }
 start
 build_container

frontend/public/json/versions.json

@@ -1,14 +1,64 @@
 [
   {
-    "name": "9001/copyparty",
-    "version": "v1.19.8",
-    "date": "2025-09-07T23:36:42Z"
+    "name": "autobrr/autobrr",
+    "version": "v1.66.1",
+    "date": "2025-09-08T10:49:03Z"
+  },
+  {
+    "name": "meilisearch/meilisearch",
+    "version": "latest",
+    "date": "2025-09-08T10:03:11Z"
+  },
+  {
+    "name": "syncthing/syncthing",
+    "version": "v2.0.8",
+    "date": "2025-09-08T08:07:18Z"
+  },
+  {
+    "name": "nzbgetcom/nzbget",
+    "version": "v25.3",
+    "date": "2025-09-01T09:47:06Z"
+  },
+  {
+    "name": "TandoorRecipes/recipes",
+    "version": "2.1.1",
+    "date": "2025-09-08T06:39:30Z"
+  },
+  {
+    "name": "firefly-iii/firefly-iii",
+    "version": "v6.3.2",
+    "date": "2025-08-19T04:08:36Z"
+  },
+  {
+    "name": "Jackett/Jackett",
+    "version": "v0.22.2441",
+    "date": "2025-09-08T06:01:57Z"
+  },
+  {
+    "name": "webmin/webmin",
+    "version": "2.501",
+    "date": "2025-09-08T04:50:25Z"
+  },
+  {
+    "name": "jeedom/core",
+    "version": "4.4.19",
+    "date": "2025-09-08T00:27:05Z"
+  },
+  {
+    "name": "steveiliop56/tinyauth",
+    "version": "v3.6.2",
+    "date": "2025-07-17T12:08:03Z"
   },
   {
     "name": "paperless-ngx/paperless-ngx",
     "version": "v2.18.4",
     "date": "2025-09-07T23:57:32Z"
   },
+  {
+    "name": "9001/copyparty",
+    "version": "v1.19.8",
+    "date": "2025-09-07T23:36:42Z"
+  },
   {
     "name": "Part-DB/Part-DB-server",
     "version": "v2.1.1",
@@ -39,26 +89,16 @@
     "version": "v6.13.2",
     "date": "2025-08-19T18:18:40Z"
   },
-  {
-    "name": "firefly-iii/firefly-iii",
-    "version": "v6.3.2",
-    "date": "2025-08-19T04:08:36Z"
-  },
   {
     "name": "runtipi/runtipi",
-    "version": "nightly",
-    "date": "2025-09-07T12:16:33Z"
+    "version": "v4.4.0",
+    "date": "2025-09-02T19:26:18Z"
   },
   {
     "name": "semaphoreui/semaphore",
     "version": "v2.17.0-beta1",
     "date": "2025-09-07T08:56:50Z"
   },
-  {
-    "name": "Jackett/Jackett",
-    "version": "v0.22.2438",
-    "date": "2025-09-07T06:00:21Z"
-  },
   {
     "name": "Radarr/Radarr",
     "version": "v5.27.5.10198",
@@ -79,16 +119,6 @@
     "version": "v2.13.3.4711",
     "date": "2025-08-28T20:06:24Z"
   },
-  {
-    "name": "jeedom/core",
-    "version": "4.4.19",
-    "date": "2025-09-07T00:27:07Z"
-  },
-  {
-    "name": "steveiliop56/tinyauth",
-    "version": "v3.6.2",
-    "date": "2025-07-17T12:08:03Z"
-  },
   {
     "name": "rcourtman/Pulse",
     "version": "v4.14.0",
@@ -99,11 +129,6 @@
     "version": "v1.6.4",
     "date": "2025-08-18T20:22:07Z"
   },
-  {
-    "name": "autobrr/autobrr",
-    "version": "v1.66.0",
-    "date": "2025-09-06T15:07:16Z"
-  },
   {
     "name": "fuma-nama/fumadocs",
     "version": "create-fumadocs-app@15.7.10",
@@ -194,11 +219,6 @@
     "version": "2025.9.1",
     "date": "2025-09-05T11:15:21Z"
   },
-  {
-    "name": "syncthing/syncthing",
-    "version": "v2.0.7",
-    "date": "2025-09-05T10:18:24Z"
-  },
   {
     "name": "zitadel/zitadel",
     "version": "v4.1.2",
@@ -234,11 +254,6 @@
     "version": "v1.0.0-beta17",
     "date": "2025-09-04T21:30:14Z"
   },
-  {
-    "name": "TandoorRecipes/recipes",
-    "version": "2.1.0",
-    "date": "2025-09-04T20:24:47Z"
-  },
   {
     "name": "mongodb/mongo",
     "version": "r7.0.24",
@@ -259,11 +274,6 @@
     "version": "v0.107.65",
     "date": "2025-08-20T14:02:28Z"
   },
-  {
-    "name": "webmin/webmin",
-    "version": "2.500",
-    "date": "2025-09-04T17:44:27Z"
-  },
   {
     "name": "ollama/ollama",
     "version": "v0.11.10",
@@ -454,11 +464,6 @@
     "version": "preview-issue-description",
     "date": "2025-09-01T12:21:58Z"
   },
-  {
-    "name": "nzbgetcom/nzbget",
-    "version": "v25.3",
-    "date": "2025-09-01T09:47:06Z"
-  },
   {
     "name": "grokability/snipe-it",
     "version": "v8.3.1",
@@ -574,11 +579,6 @@
     "version": "v3.5.1",
     "date": "2025-08-27T09:21:19Z"
   },
-  {
-    "name": "meilisearch/meilisearch",
-    "version": "latest",
-    "date": "2025-08-26T14:14:42Z"
-  },
   {
     "name": "evcc-io/evcc",
     "version": "0.207.5",

misc/build.func

@@ -26,7 +26,7 @@ elif command -v wget >/dev/null 2>&1; then
 fi
 # This function enables error handling in the script by setting options and defining a trap for the ERR signal.
 catch_errors() {
-  set -Eeuo pipefail
+  set -Eeo pipefail
   trap 'error_handler $LINENO "$BASH_COMMAND"' ERR
 }
 
@@ -200,41 +200,32 @@ ssh_check() {
 
 base_settings() {
   # Default Settings
-  CT_TYPE="1"
-  DISK_SIZE="4"
-  CORE_COUNT="1"
-  RAM_SIZE="1024"
-  VERBOSE="${1:-no}"
-  PW=""
-  CT_ID=$NEXTID
-  HN=$NSAPP
-  BRG="vmbr0"
-  NET="dhcp"
-  IPV6_METHOD="none"
-  IPV6_STATIC=""
-  GATE=""
-  APT_CACHER=""
-  APT_CACHER_IP=""
-  MTU=""
-  SD=""
-  NS=""
-  MAC=""
-  VLAN=""
-  SSH="no"
-  SSH_AUTHORIZED_KEY=""
-  TAGS="community-script;"
-  ENABLE_FUSE="${1:-no}"
-  ENABLE_TUN="${1:-no}"
-
-  # Override default settings with variables from ct script
-  CT_TYPE=${var_unprivileged:-$CT_TYPE}
-  DISK_SIZE=${var_disk:-$DISK_SIZE}
-  CORE_COUNT=${var_cpu:-$CORE_COUNT}
-  RAM_SIZE=${var_ram:-$RAM_SIZE}
-  VERB=${var_verbose:-$VERBOSE}
-  TAGS="${TAGS}${var_tags:-}"
-  ENABLE_FUSE="${var_fuse:-$ENABLE_FUSE}"
-  ENABLE_TUN="${var_tun:-$ENABLE_TUN}"
+  CT_TYPE=${var_unprivileged:-"1"}
+  DISK_SIZE=${var_disk:-"4"}
+  CORE_COUNT=${var_cpu:-"1"}
+  RAM_SIZE=${var_ram:-"1024"}
+  VERBOSE=${var_verbose:-"${1:-no}"}
+  PW=${var_pw:-""}
+  CT_ID=${var_ctid:-$NEXTID}
+  HN=${var_hostname:-$NSAPP}
+  BRG=${var_brg:-"vmbr0"}
+  NET=${var_net:-"dhcp"}
+  IPV6_METHOD=${var_ipv6_method:-"none"}
+  IPV6_STATIC=${var_ipv6_static:-""}
+  GATE=${var_gateway:-""}
+  APT_CACHER=${var_apt_cacher:-""}
+  APT_CACHER_IP=${var_apt_cacher_ip:-""}
+  MTU=${var_mtu:-""}
+  SD=${var_storage:-""}
+  NS=${var_ns:-""}
+  MAC=${var_mac:-""}
+  VLAN=${var_vlan:-""}
+  SSH=${var_ssh:-"no"}
+  SSH_AUTHORIZED_KEY=${var_ssh_authorized_key:-""}
+  UDHCPC_FIX=${var_udhcpc_fix:-""}
+  TAGS="community-script;${var_tags:-}"
+  ENABLE_FUSE=${var_fuse:-"${1:-no}"}
+  ENABLE_TUN=${var_tun:-"${1:-no}"}
 
   # Since these 2 are only defined outside of default_settings function, we add a temporary fallback. TODO: To align everything, we should add these as constant variables (e.g. OSTYPE and OSVERSION), but that would currently require updating the default_settings function for all existing scripts
   if [ -z "$var_os" ]; then
@@ -244,6 +235,7 @@ base_settings() {
     var_version="12"
   fi
 }
+
 write_config() {
   mkdir -p /opt/community-scripts
   # This function writes the configuration to a file.
@@ -354,7 +346,7 @@ echo_default() {
   echo -e "${DISKSIZE}${BOLD}${DGN}Disk Size: ${BGN}${DISK_SIZE} GB${CL}"
   echo -e "${CPUCORE}${BOLD}${DGN}CPU Cores: ${BGN}${CORE_COUNT}${CL}"
   echo -e "${RAMSIZE}${BOLD}${DGN}RAM Size: ${BGN}${RAM_SIZE} MiB${CL}"
-  if [ "$VERB" == "yes" ]; then
+  if [ "$VERBOSE" == "yes" ]; then
     echo -e "${SEARCH}${BOLD}${DGN}Verbose Mode: ${BGN}Enabled${CL}"
   fi
   echo -e "${CREATING}${BOLD}${BL}Creating a ${APP} LXC using the above default settings${CL}"