fix: pmg - split no-nag script into separate config files

The subscription nag disabling logic is now written to two distinct apt config files, one for proxmoxlib.js and one for pmgmanagerlib-mobile.js, fixing issue #7416

ct/audiobookshelf.sh

@@ -9,7 +9,7 @@ APP="audiobookshelf"
 var_tags="${var_tags:-podcast;audiobook}"
 var_cpu="${var_cpu:-2}"
 var_ram="${var_ram:-2048}"
-var_disk="${var_disk:-5}"
+var_disk="${var_disk:-4}"
 var_os="${var_os:-debian}"
 var_version="${var_version:-12}"
 var_unprivileged="${var_unprivileged:-1}"
@@ -20,19 +20,15 @@ color
 catch_errors
 
 function update_script() {
-  header_info
+    header_info
-  check_container_storage
+    check_container_storage
-  check_container_resources
+    check_container_resources
-  if [[ ! -f /etc/default/audiobookshelf ]]; then
+    if [[ ! -f /etc/apt/trusted.gpg.d/audiobookshelf-ppa.asc ]]; then
-    msg_error "No ${APP} Installation Found!"
+        msg_error "No ${APP} Installation Found!"
+        exit
+    fi
+    echo "This application receives updates through the APT package manager."
     exit
-  fi
-
-  msg_info "Updating $APP LXC"
-  $STD apt-get update
-  $STD apt-get -y upgrade
-  msg_ok "Updated $APP LXC"
-  exit
 }
 
 start

frontend/public/json/audiobookshelf.json

@@ -6,7 +6,7 @@
   ],
   "date_created": "2024-05-02",
   "type": "ct",
-  "updateable": true,
+  "updateable": false,
   "privileged": false,
   "interface_port": 13378,
   "documentation": "https://www.audiobookshelf.org/guides/",
@@ -21,7 +21,7 @@
       "resources": {
         "cpu": 2,
         "ram": 2048,
-        "hdd": 5,
+        "hdd": 4,
         "os": "debian",
         "version": "12"
       }

install/audiobookshelf-install.sh

@@ -13,18 +13,12 @@ setting_up_container
 network_check
 update_os
 
-msg_info "Installing Dependencies"
+msg_info "Installing audiobookshelf"
-$STD apt-get install -y ffmpeg
-msg_ok "Installed Dependencies"
-
-msg_info "Setup audiobookshelf"
 curl -fsSL https://advplyr.github.io/audiobookshelf-ppa/KEY.gpg >/etc/apt/trusted.gpg.d/audiobookshelf-ppa.asc
 echo "deb [signed-by=/etc/apt/trusted.gpg.d/audiobookshelf-ppa.asc] https://advplyr.github.io/audiobookshelf-ppa ./" >/etc/apt/sources.list.d/audiobookshelf.list
-$STD apt update
+$STD apt-get update
-$STD apt install -y audiobookshelf
+$STD apt install audiobookshelf
-echo "FFMPEG_PATH=/usr/bin/ffmpeg" >>/etc/default/audiobookshelf
+msg_ok "Installed audiobookshelf"
-echo "FFPROBE_PATH=/usr/bin/ffprobe" >>/etc/default/audiobookshelf
-msg_ok "Setup audiobookshelf"
 
 motd_ssh
 customize

tools/pve/post-pmg-install.sh

@@ -250,15 +250,12 @@ EOF
     whiptail --backtitle "Proxmox VE Helper Scripts" --msgbox --title "Support Subscriptions" \
       "Supporting the software's development team is essential.\nPlease consider buying a subscription." 10 58
     msg_info "Disabling subscription nag"
-    cat <<'EOF' >/etc/apt/apt.conf.d/no-nag-script
+    cat >/etc/apt/apt.conf.d/no-nag-script <<'EOF'
-DPkg::Post-Invoke {
+DPkg::Post-Invoke { "if [ -s /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js ] && ! grep -q -F 'NoMoreNagging' /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js; then sed -i '/data\.status/{s/\!//;s/active/NoMoreNagging/}' /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js; fi"; };
-  "if [ -s /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js ] && ! grep -q -F 'NoMoreNagging' /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js; then
+EOF
-     sed -i '/data\.status/{s/\\!//;s/active/NoMoreNagging/}' /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js;
+
-   fi";
+    cat >/etc/apt/apt.conf.d/no-nag-script-pmgmanagerlib-mobile <<'EOF'
-  "if [ -s /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js ] && ! grep -q -F 'NoMoreNagging' /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js; then
+DPkg::Post-Invoke { "if [ -s /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js ] && ! grep -q -F 'NoMoreNagging' /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js; then sed -i '/data\.status/{s/\!//;s/active/NoMoreNagging/}' /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js; fi"; };
-     sed -i '/data\.status/{s/\\!//;s/active/NoMoreNagging/}' /usr/share/javascript/pmg-gui/js/pmgmanagerlib-mobile.js;
-   fi";
-};
 EOF
     msg_ok "Disabled subscription nag (clear browser cache!)"
     ;;