fix 🐛: Fix PR check job condition #14

Closed

Jose wants to merge 0 commits from dev into main

pull from: dev

merge into: Jose:main

Jose:main

Conversation 2 Commits - Files Changed - +168 -166

Jose commented 2026-02-14 09:40:36 +01:00

Owner

Copy Link

This commit addresses an issue where the PR check job was not running as expected. The condition for triggering the job has been corrected to ensure it runs properly under all circumstances.

This commit addresses an issue where the PR check job was not running as expected. The condition for triggering the job has been corrected to ensure it runs properly under all circumstances.

Jose added 7 commits 2026-02-14 09:40:36 +01:00

feat ✨: Add PR check workflow for Gitleaks and lint tests ... aad77acf42

This commit introduces a new pull request (PR) check workflow that includes Gitleaks for security scanning and lint tests to ensure code quality.

refactor ♻️: Refactor PR check workflow by consolidating steps and removing redundant code ... 945717ffbb

This refactoring consolidates the steps in the PR check workflow, reducing redundancy and improving efficiency.

fix 🐛: Fix typo in PR check workflow comments ... 1733801fe5

Corrected a minor spelling error in the comments of the pull request check workflow to improve readability and clarity.

fix 🐛: Fix typo in PR check comment body ... a0138b1bea

Corrected a minor spelling error in the comment body of the pull request check to improve readability and accuracy.

refactor ♻️: Refactor condition for handle_failures to run regardless of previous job results ... dfda760d2c

This refactoring ensures that the `handle_failures` function is executed irrespective of the outcomes of previous jobs, improving the robustness and reliability of the system.

docs 📝: Update README title and compatibility matrix format ... eb5eaf7887

Updated the README title to be more descriptive and restructured the compatibility matrix for better readability.

fix 🐛: Fix PR check job condition ... fc3b5e8507

This commit addresses an issue where the PR check job was not running as expected. The condition for triggering the job has been corrected to ensure it runs properly under all circumstances.

gitea-actions bot reviewed 2026-02-14 09:40:58 +01:00

gitea-actions bot left a comment

Copy Link

Review Summary

• .gitea/workflows/pr-check-yaml: The provided Git diff shows the deletion of a workflow file named pr-check-yaml. This workflow appears to be designed for CI checks, including leak testing, linting (markdown and yaml), and handling success or failure of those checks. As the file is deleted, it's impossible to review its logic, security, performance, and maintainability based on the provided context. However, if this workflow was previously in use and has been intentionally removed, it would be worth considering implementing an alternative solution for CI checks, leak testing, and linting to ensure a secure, efficient, and maintainable development process. Since the file is deleted, I cannot provide specific issues with Score >= 2. LGTM (Logic review not applicable due to deleted file)
• .gitea/workflows/pr-check.yaml: This Git diff represents a new workflow file named pr-check.yaml for Gitea. The workflow automates lint checks and security scans on pull requests. Here's the summary of changes: The workflow runs two main jobs: "leak_test" for running a tool called Gitleaks to detect sensitive data leaks, and "lint_test" for running markdownlint, yamllint, ansible-lint for linting various file types. If either of these tests fail, the PR will be labeled with "ci-failed", and a comment will be added stating the failures. If both tests pass, the PR will be labeled as "ci-passed" and the previous "ci-failed" label (if any) will be removed. The PR state is also updated to open if it was previously closed. The workflow includes steps for installing Node.js, Python, and their respective dependencies, as well as setting up the environment variables needed for the workflow to function. Overall, this looks like a well-structured and useful workflow for ensuring code quality and security in a Git repository. Here's the LGTM message: LGTM
• README.md: Summary: Rename the title and make minor adjustments to the compatibility matrix in the README.md file. Comment: [Score: 2] Renamed the title to match the naming convention for README files. This change improves readability and consistency within the project's documentation. No other issues were found in this diff with a score >= 2.

# Review Summary * **.gitea/workflows/pr-check-yaml**: The provided Git diff shows the deletion of a workflow file named `pr-check-yaml`. This workflow appears to be designed for CI checks, including leak testing, linting (markdown and yaml), and handling success or failure of those checks. As the file is deleted, it's impossible to review its logic, security, performance, and maintainability based on the provided context. However, if this workflow was previously in use and has been intentionally removed, it would be worth considering implementing an alternative solution for CI checks, leak testing, and linting to ensure a secure, efficient, and maintainable development process. Since the file is deleted, I cannot provide specific issues with Score >= 2. LGTM (Logic review not applicable due to deleted file) * **.gitea/workflows/pr-check.yaml**: This Git diff represents a new workflow file named `pr-check.yaml` for Gitea. The workflow automates lint checks and security scans on pull requests. Here's the summary of changes: The workflow runs two main jobs: "leak_test" for running a tool called Gitleaks to detect sensitive data leaks, and "lint_test" for running markdownlint, yamllint, ansible-lint for linting various file types. If either of these tests fail, the PR will be labeled with "ci-failed", and a comment will be added stating the failures. If both tests pass, the PR will be labeled as "ci-passed" and the previous "ci-failed" label (if any) will be removed. The PR state is also updated to open if it was previously closed. The workflow includes steps for installing Node.js, Python, and their respective dependencies, as well as setting up the environment variables needed for the workflow to function. Overall, this looks like a well-structured and useful workflow for ensuring code quality and security in a Git repository. Here's the LGTM message: ``` LGTM ``` * **README.md**: **Summary:** Rename the title and make minor adjustments to the compatibility matrix in the README.md file. Comment: [Score: 2] Renamed the title to match the naming convention for README files. This change improves readability and consistency within the project's documentation. No other issues were found in this diff with a score >= 2.

gitea-actions bot commented 2026-02-14 09:41:22 +01:00

Copy Link

❌ CI checks failed.

Leak: failure
Lint: success

<!--ci-failed-comment--> ❌ CI checks failed. Leak: failure Lint: success

gitea-actions bot closed this pull request 2026-02-14 09:41:23 +01:00

Some checks failed

Hide all checks

ansible-lint / Ansible Lint (push) Successful in 11s

Details

Gitleaks Scan / gitleaks (push) Successful in 5s

Details

Markdown Lint / markdown-lint (push) Successful in 5s

Details

ai-reviews / Review PR (pull_request) Successful in 21s

Details

PR check / Gitleaks (pull_request) Failing after 6s

Details

PR check / lint tests (pull_request) Successful in 13s

Details

PR check / handle_failures (pull_request) Successful in 1s

Details

PR check / handle_success (pull_request) Has been skipped

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Documentation

bug

Something is not working

ci-failed

action test workflow failed

ci-pass

action test workflow pass

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

source

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Jose

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Jose/ansible_role_proxmox_provision#14