Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor ♻️: Refactor Gitleaks command option from --config-path to --config #17

Closed
Jose wants to merge 0 commits from dev into main
pull from: dev
merge into: Jose:main
Conversation 2 Commits - Files Changed - +202 -169
Jose commented 2026-02-14 10:06:47 +01:00
Owner
Copy Link

Updated the configuration path option for Gitleaks from '--config-path' to '--config' to simplify usage and improve consistency with other tools.

Updated the configuration path option for Gitleaks from '--config-path' to '--config' to simplify usage and improve consistency with other tools.
Jose added 11 commits 2026-02-14 10:06:47 +01:00
feat ✨: Add PR check workflow for Gitleaks and lint tests
Some checks failed
ansible-lint / Ansible Lint (push) Failing after 6s
Details
Gitleaks Scan / gitleaks (push) Successful in 5s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
aad77acf42 
This commit introduces a new pull request (PR) check workflow that includes Gitleaks for security scanning and lint tests to ensure code quality.
refactor ♻️: Refactor PR check workflow by consolidating steps and removing redundant code
Some checks failed
ansible-lint / Ansible Lint (push) Failing after 6s
Details
Gitleaks Scan / gitleaks (push) Successful in 5s
Details
Markdown Lint / markdown-lint (push) Successful in 7s
Details
945717ffbb 
This refactoring consolidates the steps in the PR check workflow, reducing redundancy and improving efficiency.
fix 🐛: Fix typo in PR check workflow comments
Some checks failed
ansible-lint / Ansible Lint (push) Failing after 6s
Details
Gitleaks Scan / gitleaks (push) Successful in 4s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
1733801fe5 
Corrected a minor spelling error in the comments of the pull request check workflow to improve readability and clarity.
fix 🐛: Fix typo in PR check comment body
Some checks failed
ansible-lint / Ansible Lint (push) Successful in 11s
Details
Gitleaks Scan / gitleaks (push) Successful in 4s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 19s
Details
PR check / Gitleaks (pull_request) Failing after 5s
Details
PR check / lint tests (pull_request) Successful in 14s
Details
PR check / handle_failures (pull_request) Has been skipped
Details
PR check / handle_success (pull_request) Has been skipped
Details
a0138b1bea 
Corrected a minor spelling error in the comment body of the pull request check to improve readability and accuracy.
refactor ♻️: Refactor condition for handle_failures to run regardless of previous job results
Some checks failed
ansible-lint / Ansible Lint (push) Failing after 6s
Details
Gitleaks Scan / gitleaks (push) Successful in 6s
Details
ai-reviews / Review PR (pull_request) Successful in 19s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
PR check / Gitleaks (pull_request) Failing after 5s
Details
PR check / lint tests (pull_request) Failing after 9s
Details
PR check / handle_failures (pull_request) Successful in 2s
Details
PR check / handle_success (pull_request) Has been skipped
Details
dfda760d2c 
This refactoring ensures that the `handle_failures` function is executed irrespective of the outcomes of previous jobs, improving the robustness and reliability of the system.
docs 📝: Update README title and compatibility matrix format
Some checks failed
ansible-lint / Ansible Lint (push) Failing after 6s
Details
Gitleaks Scan / gitleaks (push) Successful in 4s
Details
Markdown Lint / markdown-lint (push) Successful in 6s
Details
eb5eaf7887 
Updated the README title to be more descriptive and restructured the compatibility matrix for better readability.
fix 🐛: Fix PR check job condition
Some checks failed
ansible-lint / Ansible Lint (push) Successful in 11s
Details
Gitleaks Scan / gitleaks (push) Successful in 5s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 21s
Details
PR check / Gitleaks (pull_request) Failing after 6s
Details
PR check / lint tests (pull_request) Successful in 13s
Details
PR check / handle_failures (pull_request) Successful in 1s
Details
PR check / handle_success (pull_request) Has been skipped
Details
fc3b5e8507 
This commit addresses an issue where the PR check job was not running as expected. The condition for triggering the job has been corrected to ensure it runs properly under all circumstances.
docs 📝: Update README.md section title and minor formatting
Some checks failed
ansible-lint / Ansible Lint (push) Successful in 10s
Details
Gitleaks Scan / gitleaks (push) Successful in 4s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 28s
Details
PR check / Gitleaks (pull_request) Failing after 4s
Details
PR check / lint tests (pull_request) Successful in 13s
Details
PR check / handle_failures (pull_request) Successful in 1s
Details
PR check / handle_success (pull_request) Has been skipped
Details
e21f9bd002 
Corrected the title of a section in the README.md file and made some minor formatting adjustments for better readability.
chore 📦: Update Gitleaks configuration and README
Some checks failed
ansible-lint / Ansible Lint (push) Successful in 12s
Details
Gitleaks Scan / gitleaks (push) Failing after 5s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
c9a6f0e092 
Add `--config-path .gitleaks.toml` to pr-check.yaml and create a new `.gitleaks.toml` file with allowlist and rules for security scanning. Rename 'API utilities' to 'Utilities' in the README.md table.
docs 📝: Comment out allowlist rule for badge URLs in README
Some checks failed
ansible-lint / Ansible Lint (push) Successful in 12s
Details
Gitleaks Scan / gitleaks (push) Successful in 4s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 30s
Details
PR check / Gitleaks (pull_request) Failing after 4s
Details
PR check / lint tests (pull_request) Successful in 15s
Details
PR check / handle_failures (pull_request) Successful in 2s
Details
PR check / handle_success (pull_request) Has been skipped
Details
dbd70e61ce 
Updated the README to comment out the allowlist rule for badge URLs, as it is no longer necessary.
refactor ♻️: Refactor Gitleaks command option from --config-path to --config
Some checks failed
ansible-lint / Ansible Lint (push) Successful in 12s
Details
Gitleaks Scan / gitleaks (push) Successful in 5s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 35s
Details
PR check / Gitleaks (pull_request) Failing after 5s
Details
PR check / lint tests (pull_request) Successful in 13s
Details
PR check / handle_failures (pull_request) Successful in 2s
Details
PR check / handle_success (pull_request) Has been skipped
Details
7b5c802689 
Updated the configuration path option for Gitleaks from '--config-path' to '--config' to simplify usage and improve consistency with other tools.
gitea-actions bot reviewed 2026-02-14 10:07:43 +01:00
gitea-actions bot left a comment
Copy Link

Review Summary

  • .gitea/workflows/pr-check-yaml: This workflow file has been deleted. Previously, it was running various checks such as a leak test, lint tests, and handling success or failure scenarios. However, the deletion of this file means that these checks are no longer being performed. If these checks were necessary for your project, I'd recommend creating a new workflow with an updated configuration to ensure proper testing and security. Here is a brief summary of what was previously in the file: - The workflow was triggered on pull request events (opened and synchronized). - It consisted of jobs called leak_test, lint_test, handle_failures, and handle_success. - Each job had specific steps for checking out code, installing necessary tools, running tests, commenting on the PR if checks failed, and handling success scenarios by updating comments and reopening the PR. Since this file has been deleted, it's essential to ensure that alternative methods are in place to perform these checks or handle the corresponding actions for your project.
  • .gitea/workflows/pr-check.yaml: Summary: This Git diff represents the creation of a new workflow file for Continuous Integration (CI) checks in a Gitea repository. The checks include leak testing, linting (markdown and yaml), and handling success or failure cases by commenting on the pull request, labeling it, closing or reopening it accordingly.
  • .gitleaks.toml: Changes added a Gitleaks configuration file to ignore specific false positives and apply rules for API keys and Sidekiq secrets
  • README.md: Summary: This Git diff updates the README file with minor improvements and additions. It modifies the title, renames a section, and adjusts some formatting. No critical or major issues are found.
# Review Summary * **.gitea/workflows/pr-check-yaml**: This workflow file has been deleted. Previously, it was running various checks such as a leak test, lint tests, and handling success or failure scenarios. However, the deletion of this file means that these checks are no longer being performed. If these checks were necessary for your project, I'd recommend creating a new workflow with an updated configuration to ensure proper testing and security. Here is a brief summary of what was previously in the file: - The workflow was triggered on pull request events (opened and synchronized). - It consisted of jobs called leak_test, lint_test, handle_failures, and handle_success. - Each job had specific steps for checking out code, installing necessary tools, running tests, commenting on the PR if checks failed, and handling success scenarios by updating comments and reopening the PR. Since this file has been deleted, it's essential to ensure that alternative methods are in place to perform these checks or handle the corresponding actions for your project. * **.gitea/workflows/pr-check.yaml**: **Summary:** This Git diff represents the creation of a new workflow file for Continuous Integration (CI) checks in a Gitea repository. The checks include leak testing, linting (markdown and yaml), and handling success or failure cases by commenting on the pull request, labeling it, closing or reopening it accordingly. * **.gitleaks.toml**: **Changes added a Gitleaks configuration file to ignore specific false positives and apply rules for API keys and Sidekiq secrets** * **README.md**: **Summary:** This Git diff updates the README file with minor improvements and additions. It modifies the title, renames a section, and adjusts some formatting. No critical or major issues are found.
README.md
@@ -1,4 +1,4 @@
# ansible_role_proxmox_provision
# README ansible_role_proxmox_provision
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Score: 2] The title is updated from ansible_role_proxmox_provision to the more descriptive and consistent README ansible_role_proxmox_provision.

[Score: 2] The title is updated from `ansible_role_proxmox_provision` to the more descriptive and consistent `README ansible_role_proxmox_provision`.
README.md
@@ -8,3 +8,3 @@
[![Proxmox](https://img.shields.io/badge/Proxmox-9-orange?logo=proxmox&logoColor=white)](https://www.proxmox.com/)
## 📌 Key Features
## 📌 Features
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Score: 2] The heading for the "Key Features" section is updated from "📌 Key Features" to "Features".

[Score: 2] The heading for the "Key Features" section is updated from "📌 Key Features" to "Features".
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Lines 7-10] [Score: 2] The Ansible and Proxmox version badges are added to the README, providing a quick glance at the supported versions for this role.

[Lines 7-10] [Score: 2] The Ansible and Proxmox version badges are added to the README, providing a quick glance at the supported versions for this role.
README.md
@@ -11,3 +10,4 @@
## 📌 Features
✅ **Proxmox VE Optimized** - Specifically designed for Proxmox Virtual Environment
⬜ **Idempotent** - Safe to run multiple times
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Lines 12-13] [Score: 2] The description of the "Proxmox VE Optimized" feature is updated but remains the same in functionality.

[Lines 12-13] [Score: 2] The description of the "Proxmox VE Optimized" feature is updated but remains the same in functionality.
README.md
@@ -18,7 +18,7 @@
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Score: 2] The heading for the "Compatibility Matrix" is updated from "📊 Compatibility Chart" to a more familiar "Compatibility Matrix".

[Score: 2] The heading for the "Compatibility Matrix" is updated from "📊 Compatibility Chart" to a more familiar "Compatibility Matrix".
README.md
@@ -19,3 +19,3 @@
## 📊 Compatibility Matrix
| Feature | VE 7 | VE 8 | VE 9 |
| Feature \ Proxmox Version| 7 | 8 | 9 |
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Score: 2] The format for the compatibility matrix is updated to a table with each row representing a feature and columns representing supported versions.

[Score: 2] The format for the compatibility matrix is updated to a table with each row representing a feature and columns representing supported versions.
README.md
@@ -27,3 +27,3 @@
| Logrotate protection | ✅ | ✅ | ✅ |
| Powertop auto-tune | ✅ | ✅ | ✅ |
| API utilities | ✅ | ✅ | ✅ |
| Utilities | ✅ | ✅ | ✅ |
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Score: 2] The description for the "Utilities" feature is updated but remains the same in functionality.

[Score: 2] The description for the "Utilities" feature is updated but remains the same in functionality.
README.md
@@ -47,3 +47,3 @@
│ ├── subscription.yml # Subscription nag removal
│ ├── swap.yml # Swap setup
│ └── utilities.yml # API utilities installation
│ └── utilities.yml # Utilities installation
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Score: 2] The comment for the "utilities.yml" file is updated from "API utilities installation" to "Utilities installation".

[Score: 2] The comment for the "utilities.yml" file is updated from "API utilities installation" to "Utilities installation".
b/.gitleaks.toml
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Score: 2] Title added, ensures the configuration file is easily identifiable and organized.

[Score: 2] Title added, ensures the configuration file is easily identifiable and organized.
b/.gitleaks.toml
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Lines 6-30] [Score: 2] Adding allowlist rules for specific patterns that may trigger false positives, improving maintainability and accuracy of the scan results.

[Lines 6-30] [Score: 2] Adding allowlist rules for specific patterns that may trigger false positives, improving maintainability and accuracy of the scan results.
gitea-actions bot commented 2026-02-14 10:07:43 +01:00
Copy Link

[Lines 20-30] [Score: 2] Adding rules for detecting generic API keys and Sidekiq secrets, enhancing security by identifying sensitive data in the codebase.

[Lines 20-30] [Score: 2] Adding rules for detecting generic API keys and Sidekiq secrets, enhancing security by identifying sensitive data in the codebase.
gitea-actions bot commented 2026-02-14 10:08:05 +01:00
Copy Link

❌ CI checks failed.

Leak: failure
Lint: success

<!--ci-failed-comment--> ❌ CI checks failed. Leak: failure Lint: success
gitea-actions bot closed this pull request 2026-02-14 10:08:05 +01:00
Some checks failed
ansible-lint / Ansible Lint (push) Successful in 12s
Details
Gitleaks Scan / gitleaks (push) Successful in 5s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 35s
Details
PR check / Gitleaks (pull_request) Failing after 5s
Details
PR check / lint tests (pull_request) Successful in 13s
Details
PR check / handle_failures (pull_request) Successful in 2s
Details
PR check / handle_success (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Documentation
bug
Something is not working
 ci-failed
action test workflow failed
 ci-pass
action test workflow pass
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 source
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jose
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Jose/ansible_role_proxmox_provision#17
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?