Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat ✨: Add variable log2ram_host_memtotal_mb for storing host memory total in MB #37

Merged
Jose merged 1 commits from dev into main 2026-02-16 17:58:40 +01:00
Conversation 1 Commits 1 Files Changed 1 +1
Jose commented 2026-02-16 17:57:41 +01:00
Owner
Copy Link

Introduce a new variable to store the total memory of the host in megabytes, enhancing memory management and resource allocation within the system.

Introduce a new variable to store the total memory of the host in megabytes, enhancing memory management and resource allocation within the system.
Jose added 1 commit 2026-02-16 17:57:41 +01:00
feat ✨: Add variable log2ram_host_memtotal_mb for storing host memory total in MB
All checks were successful
ansible-lint / Ansible Lint (push) Successful in 12s
Details
Gitleaks Scan / gitleaks (push) Successful in 4s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 4s
Details
PR check / Gitleaks (pull_request) Successful in 5s
Details
PR check / lint tests (pull_request) Successful in 14s
Details
PR check / labeler (pull_request) Successful in 2s
Details
PR check / handle_failures (pull_request) Has been skipped
Details
PR check / handle_success (pull_request) Successful in 1s
Details
d10d80803b 
Introduce a new variable to store the total memory of the host in megabytes, enhancing memory management and resource allocation within the system.
gitea-actions bot reviewed 2026-02-16 17:57:53 +01:00
gitea-actions bot left a comment
Copy Link

Review Summary

  • defaults/main.yml: Changes Summary: This change adds a new configuration for log2ram_host_memtotal_mb which sets it to the total memory size in MB of the host. This seems like a reasonable adjustment to dynamically set memory usage limit for log2ram based on the host's actual RAM, but I would suggest adding a comment explaining why this change was made and how it impacts the system.
# Review Summary * **defaults/main.yml**: **Changes Summary:** This change adds a new configuration for `log2ram_host_memtotal_mb` which sets it to the total memory size in MB of the host. This seems like a reasonable adjustment to dynamically set memory usage limit for log2ram based on the host's actual RAM, but I would suggest adding a comment explaining why this change was made and how it impacts the system.
a/defaults/main.yml
gitea-actions bot commented 2026-02-16 17:57:53 +01:00
Copy Link

[Score: 3] This change dynamically sets the log2ram memory usage limit based on the host's actual RAM. Consider adding a comment explaining why this change was made and how it impacts the system for future maintenance purposes.

[Score: 3] This change dynamically sets the log2ram memory usage limit based on the host's actual RAM. Consider adding a comment explaining why this change was made and how it impacts the system for future maintenance purposes.
gitea-actions bot added the ci-pass label 2026-02-16 17:58:19 +01:00
Jose merged commit 1929ad13af into main 2026-02-16 17:58:40 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Documentation
bug
Something is not working
 ci-failed
action test workflow failed
 ci-pass
action test workflow pass
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 source
wontfix
This won't be fixed
No Label ci-pass
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jose
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Jose/ansible_role_proxmox_provision#37
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?