Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore 📦: Update log2ram version to 1.7.2 and add dynamic versioning in ram.yml #40

Merged
Jose merged 1 commits from dev into main 2026-02-16 18:50:08 +01:00
Conversation 1 Commits 1 Files Changed 2 +3 -2
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
defaults/main.yml
View File

@@ -38,6 +38,7 @@ log2ram_ram_percent: 10
log2ram_min_size_mb: 128
log2ram_max_size_mb: 1024
log2ram_host_memtotal_mb: "{{ ansible_memtotal_mb }}"
log2ram_version: "1.7.2"
gitea-actions commented 2026-02-16 18:49:28 +01:00
Review
Copy Link

[Score: 2] The version number is hardcoded. It's recommended to use variables or a configuration file for version control and easier updates.

[Score: 2] The version number is hardcoded. It's recommended to use variables or a configuration file for version control and easier updates.
# Journald RAM usage limit
journald_runtime_max_use: "100M"

4
tasks/ram.yml
View File

@@ -39,7 +39,7 @@
- name: ram | Download log2ram
ansible.builtin.get_url:
url: https://github.com/azlux/log2ram/archive/refs/tags/1.7.2.tar.gz
url: https://github.com/azlux/log2ram/archive/refs/tags/{{ log2ram_version }}.tar.gz
gitea-actions commented 2026-02-16 18:49:28 +01:00
Review
Copy Link

[Score: 2] The URL for downloading the package is dynamically generated based on the log2ram_version variable, ensuring the installation uses the correct version of the package.

[Score: 2] The URL for downloading the package is dynamically generated based on the `log2ram_version` variable, ensuring the installation uses the correct version of the package.
dest: /tmp/log2ram.tar.gz
mode: '0644'
register: download_archive
@@ -56,7 +56,7 @@
- name: ram | Install log2ram
ansible.builtin.command: bash install.sh
args:
chdir: "/tmp/log2ram-master"
chdir: "/tmp/log2ram-{{ log2ram_version }}"
# 'creates' makes the command idempotent by checking for the binary
creates: /usr/local/bin/log2ram
notify: Restart log2ram