Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor ♻️: Refactor task to use ansible.builtin.apt for compatibility #9

Merged
Jose merged 6 commits from dev into main 2026-02-12 18:29:11 +01:00
Conversation 2 Commits 6 Files Changed 2 +18 -2
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tasks/main.yml
View File

@@ -3,6 +3,9 @@
# Main tasks for role
# ===================
- name: Install api utilities
ansible.builtin.import_tasks: utilities.yml
gitea-actions commented 2026-02-12 18:28:19 +01:00
Review
Copy Link

[Lines 6-7] [Score: 3] Renaming two tasks with similar functionality might cause confusion in the future. Consider using a more descriptive name for clarity.

[Lines 6-7] [Score: 3] Renaming two tasks with similar functionality might cause confusion in the future. Consider using a more descriptive name for clarity.
- name: Disable enterprise repo, enable no-subscription
ansible.builtin.import_tasks: repos.yml
@@ -12,8 +15,8 @@
- name: Disable swap or tune it
ansible.builtin.import_tasks: swap.yml
- name: Stop logs from quietly murdering /
- name: Stop logs from quietly murdering the disk
gitea-actions commented 2026-02-12 18:28:19 +01:00
Review
Copy Link

[Score: 2] Slightly more descriptive task name could help with understanding. For example, "Stop logs from consuming excessive disk space".

[Score: 2] Slightly more descriptive task name could help with understanding. For example, "Stop logs from consuming excessive disk space".
ansible.builtin.import_tasks: logrotate.yml
- name: Install, auto-tune, and make it persistent
- name: Install powertop, auto-tune, and make it persistent
ansible.builtin.import_tasks: powertop.yml

13
tasks/utilities.yml Normal file
View File

@@ -0,0 +1,13 @@
---
- name: utilities | Install required system packages
ansible.builtin.apt:
name:
- python3
- python3-pip
- python3-setuptools
- python3-proxmoxer
- python3-requests
- smartmontools
- lm-sensors
state: present
update_cache: yes