Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore 📦: Update file path for non-clustered environments in fail2ban.yml #52

Merged
Jose merged 1 commits from dev into main 2026-03-02 19:03:49 +01:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
Jose commented 2026-03-02 19:02:31 +01:00
Owner
Copy Link

This commit updates the file path configuration for non-clustered environments in the fail2ban.yml file. This ensures that the correct paths are used when running fail2ban outside of a clustered environment.

This commit updates the file path configuration for non-clustered environments in the `fail2ban.yml` file. This ensures that the correct paths are used when running fail2ban outside of a clustered environment.
Jose added 1 commit 2026-03-02 19:02:31 +01:00
chore 📦: Update file path for non-clustered environments in fail2ban.yml
All checks were successful
ansible-lint / Ansible Lint (push) Successful in 15s
Details
Gitleaks Scan / gitleaks (push) Successful in 5s
Details
Markdown Lint / markdown-lint (push) Successful in 5s
Details
ai-reviews / Review PR (pull_request) Successful in 12s
Details
PR check / Gitleaks (pull_request) Successful in 4s
Details
PR check / lint tests (pull_request) Successful in 15s
Details
PR check / labeler (pull_request) Successful in 3s
Details
PR check / handle_failures (pull_request) Has been skipped
Details
PR check / handle_success (pull_request) Successful in 2s
Details
ded4fb8270 
This commit updates the file path configuration for non-clustered environments in the `fail2ban.yml` file. This ensures that the correct paths are used when running fail2ban outside of a clustered environment.
gitea-actions bot reviewed 2026-03-02 19:03:04 +01:00
gitea-actions bot left a comment
Copy Link

Review Summary

  • tasks/fail2ban.yml: Addition of host-specific firewall configuration file path for non-clustered environments (moderate improvement in maintainability).
# Review Summary * **tasks/fail2ban.yml**: Addition of host-specific firewall configuration file path for non-clustered environments (moderate improvement in maintainability).
tasks/fail2ban.yml
@@ -153,3 +153,3 @@
'/etc/pve/firewall/cluster.fw'
if clustered.stat.exists
else '/etc/pve/nodes/' + pve_node + '.fw'
else '/etc/pve/nodes/' + pve_node + '/host.fw'
gitea-actions bot commented 2026-03-02 19:03:04 +01:00
Copy Link

[Score: 2] Addition of host-specific firewall configuration file path for non-clustered environments, which helps avoid potential confusion or errors in differentiating between cluster and non-cluster configurations. However, it would be more consistent to also update the else clause in line 154 for better symmetry, as suggested below:
OLD: - else '/etc/pve/nodes/' + pve_node + '.fw'
NEW: + else '/etc/pve/nodes/' + pve_node + '/host.fw'

[Score: 2] Addition of host-specific firewall configuration file path for non-clustered environments, which helps avoid potential confusion or errors in differentiating between cluster and non-cluster configurations. However, it would be more consistent to also update the `else` clause in line 154 for better symmetry, as suggested below: OLD: - else '/etc/pve/nodes/' + pve_node + '.fw' NEW: + else '/etc/pve/nodes/' + pve_node + '/host.fw'
gitea-actions bot added the sourceci-pass labels 2026-03-02 19:03:30 +01:00
Jose merged commit 0e8abb4d38 into main 2026-03-02 19:03:49 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Documentation
bug
Something is not working
 ci-failed
action test workflow failed
 ci-pass
action test workflow pass
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 source
wontfix
This won't be fixed
No Label ci-pass source
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jose
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Jose/ansible_role_proxmox_provision#52
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?