Jose/ansible_role_proxmox_provision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore 📦: Update file path for non-clustered environments in fail2ban.yml #52

Merged
Jose merged 1 commits from dev into main 2026-03-02 19:03:49 +01:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tasks/fail2ban.yml
View File

@@ -152,7 +152,7 @@
{{
'/etc/pve/firewall/cluster.fw'
if clustered.stat.exists
else '/etc/pve/nodes/' + pve_node + '.fw'
else '/etc/pve/nodes/' + pve_node + '/host.fw'
gitea-actions commented 2026-03-02 19:03:04 +01:00
Review
Copy Link

[Score: 2] Addition of host-specific firewall configuration file path for non-clustered environments, which helps avoid potential confusion or errors in differentiating between cluster and non-cluster configurations. However, it would be more consistent to also update the else clause in line 154 for better symmetry, as suggested below:
OLD: - else '/etc/pve/nodes/' + pve_node + '.fw'
NEW: + else '/etc/pve/nodes/' + pve_node + '/host.fw'

[Score: 2] Addition of host-specific firewall configuration file path for non-clustered environments, which helps avoid potential confusion or errors in differentiating between cluster and non-cluster configurations. However, it would be more consistent to also update the `else` clause in line 154 for better symmetry, as suggested below: OLD: - else '/etc/pve/nodes/' + pve_node + '.fw' NEW: + else '/etc/pve/nodes/' + pve_node + '/host.fw'
}}
when: pve_installed.stat.exists | default(false)